Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(test-runner): ignore invalid for perform upgrade tx #1549

Merged
merged 2 commits into from
Nov 24, 2023
Merged

fix(test-runner): ignore invalid for perform upgrade tx #1549

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8a71e17
fix(test-runner): ignore invalid for perform upgrade tx
pepoviola Nov 24, 2023
cf4d251
lint
pepoviola Nov 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 14 additions & 2 deletions javascript/packages/orchestrator/src/jsapi-helpers/chainUpgrade.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,9 +128,21 @@ async function performChainUpgrade(api: ApiPromise, code: string) {
unsub();
return resolve();
} else if (result.isError) {
console.log(`Transaction Error`);
unsub();
return reject();
if (result.status.isInvalid) {
// Allow `invalid` tx, since we will validate the hash of the `code` later
// The problem being that there are forks
// Block X is build with the tx included
// X gets retracted by Y that doesn't has the tx included
// And thus the tx lands in the tx pool again
// Then another block on top of x is build that tries to include the tx again and boom
// It reports it as invalid, because it was already included
console.log(`Transaction invalid:`, JSON.stringify(result));
return resolve();
} else {
console.log(`Transaction Error:`, JSON.stringify(result));
return reject();
}
}
});
});
Expand Down