remove substrate compat #1850
remove substrate compat #1850
Conversation
There was a problem hiding this comment.
I like this example; for me it shows that it's not hard to use Substrate's signer stuff instead if people would rather do that!
There was a problem hiding this comment.
Based on the signer example I feel happy enough removing the substrate compat feature; it's not too hard plugging things like Substrate's signer stuff in, and this means we are independent and one can write SUbxt code against any version of polkadot-sdk that they want :)
|
Whoops; my suggestion broke the cargo check; I forgot about the extra import needed! |
subxt/src/book/usage/transactions.rs
Outdated
| @@ -77,7 +77,6 @@ | |||
| //! Let's see how to use each of these approaches: | |||
There was a problem hiding this comment.
I think here I'd be inclined to only show how to do (1), and then link to your example for (2) instead of showing the code here, since it's suddenly quite verbose and also not something we expect people to do so much nowadays
subxt/src/book/usage/transactions.rs
Outdated
| //! | ||
| //! If this isn't suitable/available, you can either implement [`crate::tx::Signer`] yourself to use | ||
| //! custom signing logic, or you can use some external signing logic, like so: | ||
| //! //// 2. See `subxt/examples/substrate_compat_signer.rs` how to use the polkadot-sdk signer with Subxt. |
There was a problem hiding this comment.
Nit: Maybe have this below the code block instead, something like:
"See <...> for an example on of intagratating polkadot-sdk's signer in to Subxt."
Close #1847