Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent bug when reusing type ids in hashing #1075

Merged
merged 8 commits into from
Jul 19, 2023
Merged

Prevent bug when reusing type ids in hashing #1075

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
b725367
practice TDD
tadeohepperle Jul 17, 2023
5216e25
implement a hashmap 2-phases approach
tadeohepperle Jul 17, 2023
7878d42
use nicer types
tadeohepperle Jul 18, 2023
2e148e7
add test for cache filling
tadeohepperle Jul 18, 2023
1b8b78b
Merge branch 'master' into tadeo-hepperle-prevent-reuse-of-type-ids-i…
tadeohepperle Jul 18, 2023
c9d8672
Merge branch 'master' into tadeo-hepperle-prevent-reuse-of-type-ids-i…
jsdw Jul 19, 2023
9cbb5f6
adjust test
tadeohepperle Jul 19, 2023
3d0be91
Merge branch 'master' into tadeo-hepperle-prevent-reuse-of-type-ids-i…
tadeohepperle Jul 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions metadata/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ mod from_into;
mod utils;

use scale_info::{form::PortableForm, PortableRegistry, Variant};
use std::collections::{HashMap, HashSet};
use std::collections::HashMap;
use std::sync::Arc;
use utils::ordered_map::OrderedMap;
use utils::variant_index::VariantIndex;
Expand Down Expand Up @@ -152,7 +152,7 @@ impl Metadata {
Some(crate::utils::validation::get_type_hash(
&self.types,
id,
&mut HashSet::<u32>::new(),
&mut HashMap::<u32, u32>::new(),
))
}
}
Expand Down
Loading