Strip metadata fix (#1774)

* Fix metadata stripping being too eager closes #1659 --------- Co-authored-by: James Wilson <[email protected]> Co-authored-by: Niklas Adolfsson <[email protected]>
paritytech · Oct 21, 2024 · ae0fce8 · ae0fce8
1 parent 9527165
commit ae0fce8
Show file tree

Hide file tree

Showing 7 changed files with 344 additions and 227 deletions.
diff --git a/Cargo.lock b/Cargo.lock
diff --git a/artifacts/regressions/1659.scale b/artifacts/regressions/1659.scale
diff --git a/metadata/Cargo.toml b/metadata/Cargo.toml
@@ -29,7 +29,6 @@ hashbrown = { workspace = true }
 bitvec = { workspace = true, features = ["alloc"] }
 criterion = { workspace = true }
 scale-info = { workspace = true, features = ["bit-vec"] }
-assert_matches = { workspace = true }
 
 [lib]
 # Without this, libtest cli opts interfere with criteron benches:

diff --git a/metadata/src/lib.rs b/metadata/src/lib.rs
@@ -214,7 +214,10 @@ impl Metadata {
         MetadataHasher::new(self)
     }
 
-    /// Filter out any pallets that we don't want to keep, retaining only those that we do.
+    /// Filter out any pallets and/or runtime_apis that we don't want to keep, retaining only those that we do.
+    /// Note:
+    /// only filter by `pallet`s will not lead to significant metadata size reduction because the return types are kept to ensure that those can be decoded.
+    ///
     pub fn retain<F, G>(&mut self, pallet_filter: F, api_filter: G)
     where
         F: FnMut(&str) -> bool,