Prevent bug when reusing type ids in hashing (#1075)

* practice TDD * implement a hashmap 2-phases approach * use nicer types * add test for cache filling * adjust test --------- Co-authored-by: James Wilson <[email protected]>
paritytech · Jul 20, 2023 · 94fe352 · 94fe352
1 parent 3ca2886
commit 94fe352
Show file tree

Hide file tree

Showing 2 changed files with 139 additions and 61 deletions.
diff --git a/metadata/src/lib.rs b/metadata/src/lib.rs
@@ -20,7 +20,7 @@ mod from_into;
 mod utils;
 
 use scale_info::{form::PortableForm, PortableRegistry, Variant};
-use std::collections::{HashMap, HashSet};
+use std::collections::HashMap;
 use std::sync::Arc;
 use utils::ordered_map::OrderedMap;
 use utils::variant_index::VariantIndex;
@@ -152,7 +152,7 @@ impl Metadata {
         Some(crate::utils::validation::get_type_hash(
             &self.types,
             id,
-            &mut HashSet::<u32>::new(),
+            &mut HashMap::new(),
         ))
     }
 }