Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

dockerfiles: upgrade to ubuntu:20.04 #9753

Merged
merged 3 commits into from
Sep 13, 2021
Merged

Conversation

TriplEight
Copy link
Contributor

Polkadot companion: paritytech/polkadot#3828

I'm upgrading the CI image from being based on debian:buster to ubuntu:20.04, some details: paritytech/scripts#309
The binaries produced in our new CI image will be linked by the newer GLIBC so won't be executable in debian:

/usr/local/bin/adder-collator: /lib/x86_64-linux-gnu/libm.so.6: version `GLIBC_2.29' not found (required by /usr/local/bin/adder-collator)
/usr/local/bin/adder-collator: /usr/lib/x86_64-linux-gnu/libstdc++.so.6: version `GLIBCXX_3.4.26' not found (required by /usr/local/bin/adder-collator)

@chevdor I wanted to ask you about https://github.com/paritytech/substrate/blob/master/.maintain/Dockerfile

  • is it still used?
  • if yes, it should follow our containers policy and use ubuntu:20.04 as base
  • and have some metadata as the other images do

@TriplEight TriplEight added A3-in_progress Pull request is in progress. No review needed at this stage. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. labels Sep 10, 2021
@TriplEight TriplEight self-assigned this Sep 10, 2021
@TriplEight TriplEight requested a review from a team as a code owner September 10, 2021 17:18
Copy link
Contributor

@chevdor chevdor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chevdor
Copy link
Contributor

chevdor commented Sep 13, 2021

is it still used?

Yes, and it is critical to keep it.

if yes, it should follow our containers policy and use ubuntu:20.04 as base

I see no issue with that. Do you want to include that in the PR? If not, please open an issue and I will take care of it.

and have some metadata as the other images do

100%

@TriplEight TriplEight requested a review from bkchr September 13, 2021 12:16
@TriplEight TriplEight merged commit 7fbec2f into master Sep 13, 2021
@TriplEight TriplEight deleted the 3x8_upgrade_to_ubuntu2004 branch September 13, 2021 12:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A3-in_progress Pull request is in progress. No review needed at this stage. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants