Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

graph::ChainApi and graph::Pool reexport #9726

Merged
merged 2 commits into from
Sep 8, 2021

Conversation

tgmichel
Copy link
Contributor

@tgmichel tgmichel commented Sep 8, 2021

With #9228 ChainApi trait is only available in the test_helpers module - which's name is misleading when importing it as a dependency in a project.

This PR just reexports ChainApi and Pool - previously publicly available in sc_transaction_graph crate.

@bkchr
Copy link
Member

bkchr commented Sep 8, 2021

@tgmichel it doesnt compile :P

@tgmichel
Copy link
Contributor Author

tgmichel commented Sep 8, 2021

@tgmichel it doesnt compile :P

My bad, ChainApi was already imported in submit_local. That should fix the CI.

Edit: I don't know why https://gitlab.parity.io/parity/substrate/-/jobs/1105045 is failing though, changes in this PR are trivial.

@sorpaas sorpaas added A6-seemsok B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. labels Sep 8, 2021
@bkchr bkchr added the D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit label Sep 8, 2021
@bkchr
Copy link
Member

bkchr commented Sep 8, 2021

bot merge

@ghost
Copy link

ghost commented Sep 8, 2021

Waiting for commit status.

@ghost
Copy link

ghost commented Sep 8, 2021

Merge aborted: Checks failed for d3b77ea

@bkchr bkchr merged commit b391b82 into paritytech:master Sep 8, 2021
JoshOrndorff pushed a commit to moonbeam-foundation/substrate that referenced this pull request Sep 28, 2021
* `graph::ChainApi` and `graph::Pool` reexport

* Redundant import cleanup

(cherry picked from commit b391b82)
JoshOrndorff pushed a commit to moonbeam-foundation/substrate that referenced this pull request Sep 28, 2021
* `graph::ChainApi` and `graph::Pool` reexport

* Redundant import cleanup

(cherry picked from commit b391b82)
JoshOrndorff pushed a commit to moonbeam-foundation/substrate that referenced this pull request Sep 28, 2021
* `graph::ChainApi` and `graph::Pool` reexport

* Redundant import cleanup

(cherry picked from commit b391b82)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants