-
Notifications
You must be signed in to change notification settings - Fork 2.7k
Store election snapshot in a more memory-friendly way. #9275
Conversation
bot merge |
Waiting for commit status. |
bot merge abort |
bot merge cancel |
Merge cancelled. |
bot cancel |
bot stop |
\benchmark pallet pallet_election_provider_multi_phase |
/benchmark pallet pallet_election_provider_multi_phase |
Starting benchmark for branch: kiz-rewrite-snapshot-put (vs master) Comment will be updated. |
/benchmark pallet pallet_election_provider_multi_phase |
Starting benchmark for branch: kiz-rewrite-snapshot-put (vs master) Comment will be updated. |
Co-authored-by: Guillaume Thiolliere <[email protected]>
/benchmark runtime pallet pallet_election_provider_multi_phase |
Benchmark Runtime Pallet for branch "kiz-rewrite-snapshot-put" with command cargo run --release --features=runtime-benchmarks --manifest-path=bin/node/cli/Cargo.toml -- benchmark --chain=dev --steps=50 --repeat=20 --pallet=pallet_election_provider_multi_phase --extrinsic="*" --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./frame/election-provider-multi-phase/src/weights.rs --template=./.maintain/frame-weight-template.hbs Results
|
… kiz-rewrite-snapshot-put
…/node/cli/Cargo.toml -- benchmark --chain=dev --steps=50 --repeat=20 --pallet=pallet_election_provider_multi_phase --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./frame/election-provider-multi-phase/src/weights.rs --template=./.maintain/frame-weight-template.hbs
@shawntabrizi maybe you can understand why the diff of the bot commit is kinda strange. |
…trate into kiz-rewrite-snapshot-put
Waiting for #9286 to get more insight into the weights. |
I ran the new Without:
With:
which is pretty small. |
bot merge |
Waiting for commit status. |
Will change the storage write of snapshot to a more efficient way. This will allow us to use our heap max limit more efficiently and store larger snapshots.
Since this is not a logical change, I will not mark for audit.