-
Notifications
You must be signed in to change notification settings - Fork 2.7k
Include StorageInfo
in Benchmarking Pipeline
#9090
Conversation
/benchmark runtime pallet pallet_balances |
Finished benchmark for branch: shawntabrizi-benchmarking-storage-info Benchmark: Benchmark Runtime Pallet cargo run --release --features=runtime-benchmarks --manifest-path=bin/node/cli/Cargo.toml -- benchmark --chain=dev --steps=50 --repeat=20 --pallet=pallet_balances --extrinsic="*" --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./frame/balances/src/weights.rs --template=./.maintain/frame-weight-template.hbs ResultsPallet: "pallet_balances", Extrinsic: "transfer", Lowest values: [], Highest values: [], Steps: [50], Repeat: 20
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. I wonder tho how much does it take.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me
/benchmark runtime pallet frame_system |
1 similar comment
/benchmark runtime pallet frame_system |
Starting benchmark for branch: shawntabrizi-benchmarking-storage-info (vs master) Comment will be updated. |
/benchmark runtime pallet frame_system |
Benchmark Runtime Pallet for branch "shawntabrizi-benchmarking-storage-info" with command cargo run --release --features=runtime-benchmarks --manifest-path=bin/node/cli/Cargo.toml -- benchmark --chain=dev --steps=50 --repeat=20 --pallet=frame_system --extrinsic="*" --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./frame/system/src/weights.rs --template=./.maintain/frame-weight-template.hbs Results
|
… shawntabrizi-benchmarking-storage-info
…/node/cli/Cargo.toml -- benchmark --chain=dev --steps=50 --repeat=20 --pallet=frame_system --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./frame/system/src/weights.rs --template=./.maintain/frame-weight-template.hbs
bot merge |
Waiting for commit status. |
Merge aborted: Checks failed for 4e5c8a6 |
…ub.com/paritytech/substrate into shawntabrizi-benchmarking-storage-info
bot merge |
Trying merge. |
This PR is the first step to fully integrating
StorageInfo
into the benchmarking pipeline.As it sits, this PR now gives comment metadata to all the benchmarks, taking note of which storage items have been touched while running a benchmark.
Here is an example:
These comments are now added automatically to the benchmarking through the handlebars template.
This information is derived from the
StorageInfo
and the tracked prefixes from the benchmarking db.Further work will be included in the future which will pull more storage information from the
StorageInfo
such as the max size and length for PoV tracking.polkadot companion: paritytech/polkadot#3424