Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Clarify and expand ProvideInherent docs #7941

Merged
7 commits merged into from
Jan 28, 2021
Merged

Clarify and expand ProvideInherent docs #7941

7 commits merged into from
Jan 28, 2021

Conversation

JoshOrndorff
Copy link
Contributor

This PR clarifies the docs for the ProvideInherent trait to the best of my understanding.

This was referenced Jan 20, 2021
Merged
Closed
gui1117
gui1117 approved these changes Jan 28, 2021
View reviewed changes
Copy link
Contributor

@gui1117 gui1117 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

primitives/inherents/src/lib.rs Show resolved Hide resolved
@gui1117 gui1117 added A0-please_review Pull request needs code review. A2-insubstantial Pull request requires no code review (e.g., a sub-repository hash update). B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. labels Jan 28, 2021
@gui1117
Copy link
Contributor

gui1117 commented Jan 28, 2021

I think you should also merge master to make CI happy

@JoshOrndorff JoshOrndorff mentioned this pull request Jan 28, 2021
Merged
3 tasks
bkchr
bkchr approved these changes Jan 28, 2021
View reviewed changes
primitives/inherents/src/lib.rs Outdated Show resolved Hide resolved
primitives/inherents/src/lib.rs Outdated Show resolved Hide resolved
primitives/inherents/src/lib.rs Outdated Show resolved Hide resolved
primitives/inherents/src/lib.rs Outdated Show resolved Hide resolved
primitives/inherents/src/lib.rs Outdated Show resolved Hide resolved
@bkchr
Copy link
Member

bkchr commented Jan 28, 2021

bot merge

@ghost
Copy link

ghost commented Jan 28, 2021

Waiting for commit status.

@ghost ghost merged commit 68d7157 into paritytech:master Jan 28, 2021
@4meta5 4meta5 mentioned this pull request Jan 29, 2021
Merged
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@gui1117 gui1117 gui1117 approved these changes

@bkchr bkchr bkchr approved these changes

Assignees
No one assigned
Labels
A0-please_review Pull request needs code review. A2-insubstantial Pull request requires no code review (e.g., a sub-repository hash update). B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JoshOrndorff @gui1117 @bkchr