This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Subsystems memory tracking: 1. Transaction pool #4822
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NikVolf
added
A0-please_review
NikVolf
added
A3-in_progress
NikVolf
added
A0-please_review
NikVolf
force-pushed
the
nv-mem-txpool
branch
from
1e3abb6
to
c7a2fae
Compare
tomusdrw
reviewed
Feb 5, 2020
|
|
||
| /// The output of the `Hashing` function. | ||
| type Hash: | ||
| Parameter + Member + MaybeSerializeDeserialize + Debug + MaybeDisplay + SimpleBitOps + Ord | ||
| + Default + Copy + CheckEqual + sp_std::hash::Hash + AsRef<[u8]> + AsMut<[u8]>; | ||
| + Default + Copy + CheckEqual + sp_std::hash::Hash + AsRef<[u8]> + AsMut<[u8]> + MaybeMallocSizeOf; |
There was a problem hiding this comment.
Hmm, that's a pretty strong requirement to put into the runtime imho, requires bringing in a separate (parity-specific) lib to implement properly. Can't we add where clauses instead?
There was a problem hiding this comment.
Unless some exotic Hash type is used, it is implemented by default within parity-util-mem (all H*, integers, fixed arrays, Vec<u8> etc. are covered)
There was a problem hiding this comment.
And we have MaybeSerializeDeserialize there, so using exotic Hash will require some work anyway.
gavofyork
changed the title
bkchr
approved these changes
Feb 6, 2020
NikVolf
force-pushed
the
nv-mem-txpool
branch
from
d903d54
to
f9ee44c
Compare
NikVolf
force-pushed
the
nv-mem-txpool
branch
from
851df48
to
cfcee1a
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There will be extra some bounds on runtime primitives, as proposed in #4806
If some project uses exotic types for
OpaqueExtrinsic/Hash, they might need to implementMallocSizeOffor it also