Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Fix runtime interface tests on Windows #4805

Merged
merged 2 commits into from
Feb 10, 2020
Merged

Conversation

bkchr
Copy link
Member

@bkchr bkchr commented Feb 2, 2020

Fixes: #4800

@bkchr bkchr added A0-please_review Pull request needs code review. A2-insubstantial Pull request requires no code review (e.g., a sub-repository hash update). labels Feb 2, 2020
@bkchr bkchr mentioned this pull request Feb 3, 2020
@Swader
Copy link
Contributor

Swader commented Feb 4, 2020

Different error, previous location seems to pass now.

    Checking parity-util-mem v0.3.0
error[E0308]: mismatched types
  --> C:\Users\Bruno\.cargo\registry\src\github.aaakk.us.kg-1ecc6299db9ec823\parity-util-mem-0.3.0\src\allocators.rs:84:30
   |
84 |                 if HeapValidate(heap, 0, ptr) == 0 {
   |                                          ^^^ expected enum `winapi::ctypes::c_void`, found enum `std::ffi::c_void`
   |
   = note: expected raw pointer `*const winapi::ctypes::c_void`
              found raw pointer `*const std::ffi::c_void`

error[E0308]: mismatched types
  --> C:\Users\Bruno\.cargo\registry\src\github.aaakk.us.kg-1ecc6299db9ec823\parity-util-mem-0.3.0\src\allocators.rs:88:23
   |
88 |                 HeapSize(heap, 0, ptr) as usize
   |                                   ^^^ expected enum `winapi::ctypes::c_void`, found enum `std::ffi::c_void`
   |
   = note: expected raw pointer `*const winapi::ctypes::c_void`
              found raw pointer `*const std::ffi::c_void`

error: aborting due to 2 previous errors

For more information about this error, try `rustc --explain E0308`.
error: could not compile `parity-util-mem`.
warning: build failed, waiting for other jobs to finish...
error: build failed
test ui ... FAILED

failures:

---- ui stdout ----
thread 'ui' panicked at 'tests failed', C:\Users\Bruno\.cargo\registry\src\github.aaakk.us.kg-1ecc6299db9ec823\trybuild-1.0.21\src\run.rs:38:13
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace.


failures:
    ui

test result: FAILED. 0 passed; 1 failed; 0 ignored; 0 measured; 0 filtered out

error: test failed, to rerun pass '-p sp-runtime-interface --test ui'

@kianenigma
Copy link
Contributor

if the error is coming from \parity-util-mem, we are using it in substrate as well (not just soon) as of #4822.

@bkchr
Copy link
Member Author

bkchr commented Feb 7, 2020

Yeah, it seems that there are more problems that needs further fixing. However this small one makes it compile at least.

@bkchr bkchr requested a review from kianenigma February 7, 2020 14:29
@bkchr bkchr merged commit 26a4b73 into master Feb 10, 2020
@bkchr bkchr deleted the bkchr-fix-runtime-interface-tests branch February 10, 2020 13:49
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A0-please_review Pull request needs code review. A2-insubstantial Pull request requires no code review (e.g., a sub-repository hash update).
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test fails on Windows
3 participants