This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Add dedicated FeePolynomial struct
#13612
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Oliver Tale-Yazdi <[email protected]>
Signed-off-by: Oliver Tale-Yazdi <[email protected]>
Signed-off-by: Oliver Tale-Yazdi <[email protected]>
ggwpez
added
A0-please_review
joepetrowski
approved these changes
Mar 15, 2023
KiChjang
reviewed
Mar 15, 2023
KiChjang
reviewed
Mar 15, 2023
| } | ||
|
|
||
| /// Return self but discard any proof size. | ||
| pub const fn without_proof_size(&self) -> Self { |
There was a problem hiding this comment.
Why are these 2 functions needed?
There was a problem hiding this comment.
They are just convenience in cases where we want to selectively exclude specific dimensions. Currently there are only two, so it is a bit boring.
I am using them in a test as short-cut for set_proof_size(0) (arguably useful).
There was a problem hiding this comment.
I don't think this is ever useful, but actually very dangerous.
Signed-off-by: Oliver Tale-Yazdi <[email protected]>
Signed-off-by: Oliver Tale-Yazdi <[email protected]>
Signed-off-by: Oliver Tale-Yazdi <[email protected]>
KiChjang
reviewed
Mar 15, 2023
Signed-off-by: Oliver Tale-Yazdi <[email protected]>
Signed-off-by: Oliver Tale-Yazdi <[email protected]>
KiChjang
approved these changes
Mar 15, 2023
sam0x17
approved these changes
Mar 15, 2023
|
bot merge |
|
Waiting for commit status. |
breathx
pushed a commit
to gear-tech/substrate
that referenced
this pull request
Apr 22, 2023
* Add FeePolynomial struct Signed-off-by: Oliver Tale-Yazdi <[email protected]> * Add Weight::without_{ref_time, proof_size} Signed-off-by: Oliver Tale-Yazdi <[email protected]> * Docs Signed-off-by: Oliver Tale-Yazdi <[email protected]> * Cleanup code Signed-off-by: Oliver Tale-Yazdi <[email protected]> * Add docs Signed-off-by: Oliver Tale-Yazdi <[email protected]> * doc Signed-off-by: Oliver Tale-Yazdi <[email protected]> * Fix docs Signed-off-by: Oliver Tale-Yazdi <[email protected]> * docs Signed-off-by: Oliver Tale-Yazdi <[email protected]> --------- Signed-off-by: Oliver Tale-Yazdi <[email protected]>
This was referenced May 10, 2023
15 tasks
nathanwhit
pushed a commit
to nathanwhit/substrate
that referenced
this pull request
Jul 19, 2023
* Add FeePolynomial struct Signed-off-by: Oliver Tale-Yazdi <[email protected]> * Add Weight::without_{ref_time, proof_size} Signed-off-by: Oliver Tale-Yazdi <[email protected]> * Docs Signed-off-by: Oliver Tale-Yazdi <[email protected]> * Cleanup code Signed-off-by: Oliver Tale-Yazdi <[email protected]> * Add docs Signed-off-by: Oliver Tale-Yazdi <[email protected]> * doc Signed-off-by: Oliver Tale-Yazdi <[email protected]> * Fix docs Signed-off-by: Oliver Tale-Yazdi <[email protected]> * docs Signed-off-by: Oliver Tale-Yazdi <[email protected]> --------- Signed-off-by: Oliver Tale-Yazdi <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Zero logic refactor as preparation for paritytech/cumulus#2326.
Changes:
Weight::{without_ref_time, without_proof_size}.FeePolynomialto properly type the weight polynomial coefficients in a OOP manner to reusability downstream.Eventually the
WeightToFeePolynomialshould be two dimensional, but i want to keep this MR minimal for now.