Split Peerset into reputation store & ProtocolControllers

client/network/src/service.rs

@@ -620,7 +620,7 @@ where
 	}
 
 	/// Returns the list of reserved peers.
-	pub fn reserved_peers(&self) -> impl Iterator<Item = &PeerId> {
+	fn reserved_peers(&self) -> impl Iterator<Item = &PeerId> {
 		self.network_service.behaviour().user_protocol().reserved_peers()
 	}
 }

client/peerset/Cargo.toml

@@ -20,6 +20,7 @@ log = "0.4.17"
 serde_json = "1.0.85"
 wasm-timer = "0.2"
 sc-utils = { version = "4.0.0-dev", path = "../utils" }
+sp-arithmetic = { version = "6.0.0", path = "../../primitives/arithmetic" }
 
 [dev-dependencies]
 rand = "0.8.5"

client/peerset/src/lib.rs

@@ -33,6 +33,7 @@
 //! will at all time try to maintain a connection with.
 
 mod peersstate;
+mod protocol_controller;
 
 use futures::{channel::oneshot, prelude::*};
 use log::{debug, error, trace};
@@ -176,6 +177,26 @@ impl PeersetHandle {
 		// The channel can only be closed if the peerset no longer exists.
 		rx.await.map_err(|_| ())
 	}
+
+	/// Checks whether the peer has a reputation value below [`BANNED_THRESHOLD`].
+	pub fn is_banned(&self, peer_id: PeerId) -> bool {
+		todo!("will be implemented after `Peerset` is converted into shared struct");
+	}
+
+	/// Report disconnect to adjust peers reputation value.
+	pub fn report_disconnect(&self, peer_id: PeerId) {
+		todo!("will be implemented after `Peerset` is converted into shared struct");
+	}
+
+	/// Get the candidates for an outgoing connection.
+	pub fn outgoing_candidates(
+		&self,
+		count: usize,
+		ignored: HashSet<PeerId>,
+	) -> impl Iterator<Item = &PeerId> {
+		todo!("supply `count` peers with highest reputation, but not from `ignored`");
+		[].into_iter()
+	}
 }
 
 /// Message that can be sent by the peer set manager (PSM).
@@ -764,6 +785,7 @@ impl Stream for Peerset {
 }
 
 /// Reason for calling [`Peerset::dropped`].
+#[derive(Debug)]
 pub enum DropReason {
 	/// Substream or connection has been closed for an unknown reason.
 	Unknown,