Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Just a typo #13533

Merged
merged 3 commits into from
Mar 4, 2023
Merged

Just a typo #13533

merged 3 commits into from
Mar 4, 2023

Conversation

gavofyork
Copy link
Member

No description provided.

@gavofyork gavofyork added A2-insubstantial Pull request requires no code review (e.g., a sub-repository hash update). B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit T1-runtime This PR/Issue is related to the topic “runtime”. labels Mar 3, 2023
@ggwpez
Copy link
Member

ggwpez commented Mar 3, 2023

bot rebase

@paritytech-processbot
Copy link

Branch is already up-to-date

@ggwpez
Copy link
Member

ggwpez commented Mar 3, 2023 •
edited
Loading

bot bench $ pallet dev pallet_salary

PS: Pallet-salary is using the deprecated weight functions, will update manually since the bot is busy.

@command-bot
Copy link

command-bot bot commented Mar 3, 2023 •
edited
Loading

@ggwpez https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/2481517 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" pallet dev pallet_salary. Check out https://gitlab.parity.io/parity/mirrors/substrate/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 3-c52950da-a0bd-451e-870b-ea708e169dde to cancel this command or bot cancel to cancel all commands in this pull request.

@ggwpez
Update Salary weight
05fb2af 
Signed-off-by: Oliver Tale-Yazdi <[email protected]>
@ggwpez
Fix test
09bc730 
Signed-off-by: Oliver Tale-Yazdi <[email protected]>
@command-bot
Copy link

command-bot bot commented Mar 3, 2023

@ggwpez Command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" pallet dev pallet_salary has finished. Result: https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/2481517 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/2481517/artifacts/download.

@gavofyork
Copy link
Member Author

bot merge

@paritytech-processbot paritytech-processbot bot merged commit c2034a8 into master Mar 4, 2023
@paritytech-processbot paritytech-processbot bot deleted the gav-typo branch March 4, 2023 11:38
@kiltbot kiltbot mentioned this pull request Apr 3, 2023
Closed
@librelois librelois mentioned this pull request Apr 6, 2023
Closed
ukint-vs pushed a commit to gear-tech/substrate that referenced this pull request Apr 10, 2023
@gavofyork @ggwpez @ukint-vs
Just a typo (paritytech#13533)
dcb40ad 
* Typo

* Update Salary weight

Signed-off-by: Oliver Tale-Yazdi <[email protected]>

* Fix test

Signed-off-by: Oliver Tale-Yazdi <[email protected]>

---------

Signed-off-by: Oliver Tale-Yazdi <[email protected]>
Co-authored-by: Oliver Tale-Yazdi <[email protected]>
@kacperzuk-neti kacperzuk-neti mentioned this pull request Jun 23, 2023
Merged
15 tasks
nathanwhit pushed a commit to nathanwhit/substrate that referenced this pull request Jul 19, 2023
@gavofyork @ggwpez @nathanwhit
Just a typo (paritytech#13533)
2223e98 
* Typo

* Update Salary weight

Signed-off-by: Oliver Tale-Yazdi <[email protected]>

* Fix test

Signed-off-by: Oliver Tale-Yazdi <[email protected]>

---------

Signed-off-by: Oliver Tale-Yazdi <[email protected]>
Co-authored-by: Oliver Tale-Yazdi <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ggwpez ggwpez ggwpez approved these changes

@bkchr bkchr bkchr approved these changes

@KiChjang KiChjang KiChjang approved these changes

Assignees
No one assigned
Labels
A2-insubstantial Pull request requires no code review (e.g., a sub-repository hash update). B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit T1-runtime This PR/Issue is related to the topic “runtime”.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gavofyork @ggwpez @KiChjang @bkchr