[NFTs] Rework permissions model #13482

jsidorenko · 2023-02-27T17:00:26Z

This PR changes the permissions model in the pallet-nfts:

an Admin account will no longer be able to transfer or burn items it doesn't own;
to destroy the collection, there should be 0 items left;
some actions were moved from one role to another to simplify accounts management.

For simple collections, the same account usually has all the roles.
But if we take complex collections, then each role here represents a separate service with its own responsibilities (e.g. items issuance), and it should be simple to rotate the keys of those services. At the same time, the main owner's account is usually used just to setup the collection and the private key is kept in cold storage afterwards.
Given all that, a bunch of frequently called actions were moved from the Owner role to Admin or Issuer.

So, here is the list of the main actions each role will be able to do:

Owner

destroy collection
redeposit
set_team
set_collection_max_supply
lock_collection (moved from Freezer) - (make non-transferable, fix max supply, lock collection metadata/attributes) -> one time call

Admin

set_attribute/set_metadata (in the CollectionOwner namespace) (moved from Owner)
set_attributes_pre_signed (moved from Owner)
lock_item_properties (moved from Owner) - (lock item metadata/attributes) -> one time call

Freezer

lock_item_transfer
unlock_item_transfer

Issuer

mint
force_mint (with custom item config)
mint_pre_signed (moved from Owner)
update_mint_settings (moved from Owner)

This PR closes: #13171

Cumulus Companion: paritytech/cumulus#2303

mustermeiszer · 2023-03-02T09:38:26Z

@jsidorenko that looks great! Thanks for adapting so quickly.

One question:

Why is this B0-silent although it contains E0-runtime_migration?

jsidorenko · 2023-03-02T10:19:48Z

@jsidorenko that looks great! Thanks for adapting so quickly.

One question:

Why is this B0-silent although it contains E0-runtime_migration?

It's because I'm still learning the labels science :)

jsidorenko · 2023-03-10T10:31:01Z

bot rebase

paritytech-processbot · 2023-03-10T10:31:10Z

Rebased

frame/nfts/src/features/roles.rs

jsidorenko · 2023-03-10T12:23:52Z

bot bench $ pallet dev pallet_nfts

command-bot · 2023-03-10T12:23:57Z

@jsidorenko https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/2507636 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" pallet dev pallet_nfts. Check out https://gitlab.parity.io/parity/mirrors/substrate/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 35-88256996-026f-445e-a2ff-4f87c0c19640 to cancel this command or bot cancel to cancel all commands in this pull request.

ggwpez

Just looking at the migration.

frame/nfts/src/migration.rs

command-bot · 2023-03-10T13:12:39Z

@jsidorenko Command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" pallet dev pallet_nfts has finished. Result: https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/2507636 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/2507636/artifacts/download.

jsidorenko · 2023-03-10T13:53:23Z

bot bench $ pallet dev pallet_nfts

command-bot · 2023-03-10T13:53:27Z

@jsidorenko https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/2508377 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" pallet dev pallet_nfts. Check out https://gitlab.parity.io/parity/mirrors/substrate/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 40-24f5b93a-3230-4f20-8b95-50edb54d8710 to cancel this command or bot cancel to cancel all commands in this pull request.

command-bot · 2023-03-10T21:55:38Z

@jsidorenko Command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" pallet dev pallet_nfts has finished. Result: https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/2508377 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/2508377/artifacts/download.

jsidorenko · 2023-03-13T08:25:36Z

bot merge

Polkadot-Forum · 2023-03-30T10:12:44Z

This pull request has been mentioned on Polkadot Forum. There might be relevant details there:

https://forum.polkadot.network/t/polkadot-release-analysis-v0-9-40/2468/1

* Disallow admin to transfer or burn items he doesn't own * lock_collection should be accessible by collection's owner only * Allow admin to access lock_item_properties() * Fix do_lock_item_properties * Move update_mint_settings() to Issuer * Rename check_owner to check_origin * Typo * Make admin to be in charge of managing the metadata * Make admin the main attributes manager * offchain mint should be signed by Issuer * Remove the special case when the Issuer calls the mint() function * Rework burn and destroy methods * Return back item_metadatas * Don't repatriate the deposit on transfer * A bit more tests * One more test * Add migration * Chore * Clippy * Rename to owned_item * Address comments * Replace .filter_map with .find_map * Improve version validation in pre_upgrade() * ".git/.scripts/commands/bench/bench.sh" pallet dev pallet_nfts --------- Co-authored-by: parity-processbot <>

jsidorenko added 18 commits February 21, 2023 13:13

Disallow admin to transfer or burn items he doesn't own

63ec088

lock_collection should be accessible by collection's owner only

dbbaf7b

Allow admin to access lock_item_properties()

e28bcd6

Fix do_lock_item_properties

f10642c

Move update_mint_settings() to Issuer

4474b4d

Rename check_owner to check_origin

4e47f2d

Typo

822e098

Make admin to be in charge of managing the metadata

22ccfff

Make admin the main attributes manager

8670907

offchain mint should be signed by Issuer

243ac25

Remove the special case when the Issuer calls the mint() function

12ed786

Merge branch 'master' into js/rework-nfts-roles

7a4e943

Rework burn and destroy methods

afedf4d

Return back item_metadatas

955a456

Don't repatriate the deposit on transfer

9524133

A bit more tests

4cbb422

One more test

0aac9c0

Add migration

1675abe

jsidorenko added 3 commits February 27, 2023 19:05

Chore

8649482

Clippy

b88c861

Rename to owned_item

3b2600d

jsidorenko added B1-note_worthy Changes should be noted in the release notes and removed B0-silent Changes should not be mentioned in any release notes labels Mar 2, 2023

Merge remote-tracking branch 'origin/master' into js/rework-nfts-roles

fa1faf0

Address comments

ea5a23b

gilescope reviewed Mar 10, 2023

View reviewed changes

frame/nfts/src/features/roles.rs Outdated Show resolved Hide resolved

gilescope approved these changes Mar 10, 2023

View reviewed changes

Replace .filter_map with .find_map

f8292eb

jsidorenko mentioned this pull request Mar 10, 2023

Companion for #13482 paritytech/cumulus#2303

Merged

ggwpez approved these changes Mar 10, 2023

View reviewed changes

frame/nfts/src/migration.rs Outdated Show resolved Hide resolved

Improve version validation in pre_upgrade()

620d82f

".git/.scripts/commands/bench/bench.sh" pallet dev pallet_nfts

aa10c6c

paritytech-processbot bot merged commit f5c2cec into master Mar 13, 2023

paritytech-processbot bot deleted the js/rework-nfts-roles branch March 13, 2023 08:25

jsidorenko mentioned this pull request Mar 14, 2023

[NFTs] Allow to set the role to None #13591

Merged

filippoweb3 mentioned this pull request Mar 14, 2023

Update NFTS Pallet Page w3f/polkadot-wiki#4486

Merged

kiltbot mentioned this pull request Apr 3, 2023

3️⃣ [AUTOMATIC] Update Polkadot dependencies from 0.9.39 to 0.9.40 KILTprotocol/kilt-node#496

Closed

librelois mentioned this pull request Apr 6, 2023

Update substrate/polkadot/cumulus from v0.9.38 to v0.9.40 moonbeam-foundation/moonbeam#2200

Closed

redzsina added D1-audited 👍 PR contains changes to fund-managing logic that has been properly reviewed and externally audited and removed D9-needsaudit 👮 PR contains changes to fund-managing logic that should be properly reviewed and externally audited labels Apr 14, 2023

kacperzuk-neti mentioned this pull request Jun 23, 2023

Polkadot v0.9.43 liberland/liberland_substrate#295

Merged

15 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[NFTs] Rework permissions model #13482

[NFTs] Rework permissions model #13482

jsidorenko commented Feb 27, 2023 •

edited

Loading

mustermeiszer commented Mar 2, 2023

jsidorenko commented Mar 2, 2023

jsidorenko commented Mar 10, 2023

paritytech-processbot bot commented Mar 10, 2023

jsidorenko commented Mar 10, 2023

command-bot bot commented Mar 10, 2023 •

edited

Loading

ggwpez left a comment

command-bot bot commented Mar 10, 2023

jsidorenko commented Mar 10, 2023

command-bot bot commented Mar 10, 2023 •

edited

Loading

command-bot bot commented Mar 10, 2023

jsidorenko commented Mar 13, 2023

Polkadot-Forum commented Mar 30, 2023

[NFTs] Rework permissions model #13482

[NFTs] Rework permissions model #13482

Conversation

jsidorenko commented Feb 27, 2023 • edited Loading

mustermeiszer commented Mar 2, 2023

jsidorenko commented Mar 2, 2023

jsidorenko commented Mar 10, 2023

paritytech-processbot bot commented Mar 10, 2023

jsidorenko commented Mar 10, 2023

command-bot bot commented Mar 10, 2023 • edited Loading

ggwpez left a comment

Choose a reason for hiding this comment

command-bot bot commented Mar 10, 2023

jsidorenko commented Mar 10, 2023

command-bot bot commented Mar 10, 2023 • edited Loading

command-bot bot commented Mar 10, 2023

jsidorenko commented Mar 13, 2023

Polkadot-Forum commented Mar 30, 2023

jsidorenko commented Feb 27, 2023 •

edited

Loading

command-bot bot commented Mar 10, 2023 •

edited

Loading

command-bot bot commented Mar 10, 2023 •

edited

Loading