Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Allow StakingAdmin to set min_commission #13018

Merged
merged 4 commits into from
Dec 26, 2022
Merged

Allow StakingAdmin to set min_commission #13018

merged 4 commits into from
Dec 26, 2022

Conversation

Ank4n
Copy link
Contributor

@Ank4n Ank4n commented Dec 25, 2022 •
edited
Loading

Changes

  • Rename SlashCancelOrigin to AdminOrigin.
  • New call set_min_commission which can be called by AdminOrigin.

polkadot companion: paritytech/polkadot#6444.
Related to #12930.
Old PR: #12943.

@Ank4n Ank4n added the A3-in_progress Pull request is in progress. No review needed at this stage. label Dec 25, 2022
@github-actions github-actions bot added A0-please_review Pull request needs code review. and removed A3-in_progress Pull request is in progress. No review needed at this stage. labels Dec 25, 2022
@Ank4n
Copy link
Contributor Author

Ank4n commented Dec 25, 2022

/cmd queue -c bench-bot $ pallet dev pallet_staking

@command-bot
Copy link

command-bot bot commented Dec 25, 2022 •
edited
Loading

@Ank4n https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/2196739 was started for your command "$PIPELINE_SCRIPTS_DIR/bench-bot.sh" pallet dev pallet_staking. Check out https://gitlab.parity.io/parity/mirrors/substrate/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment /cmd cancel 142-9068892c-dded-4d1d-8b8f-52667ad876e1 to cancel this command or /cmd cancel to cancel all commands in this pull request.

@Ank4n Ank4n added A3-in_progress Pull request is in progress. No review needed at this stage. and removed A0-please_review Pull request needs code review. labels Dec 25, 2022
@command-bot
Copy link

command-bot bot commented Dec 25, 2022

@Ank4n Command "$PIPELINE_SCRIPTS_DIR/bench-bot.sh" pallet dev pallet_staking has finished. Result: https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/2196739 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/2196739/artifacts/download.

@Ank4n Ank4n changed the title [WIP] Staking admin can set min commission Allow StakingAdmin to set min_commission Dec 25, 2022
@Ank4n Ank4n added A0-please_review Pull request needs code review. B7-runtimenoteworthy C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit C3-medium PR touches the given topic and has a medium impact on builders. and removed A0-please_review Pull request needs code review. C1-low PR touches the given topic and has a low impact on builders. labels Dec 25, 2022
This was referenced Dec 25, 2022
Merged
Closed
rossbulat
rossbulat reviewed Dec 26, 2022
View reviewed changes
Copy link

@rossbulat rossbulat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some syntax clean up and one query about set_min_commission function. I'll also test a bit later.

frame/staking/src/pallet/mod.rs Outdated Show resolved Hide resolved
frame/staking/src/pallet/mod.rs Show resolved Hide resolved
frame/staking/src/tests.rs Outdated Show resolved Hide resolved
frame/staking/src/tests.rs Outdated Show resolved Hide resolved
kianenigma
kianenigma approved these changes Dec 26, 2022
View reviewed changes
Copy link
Contributor

@kianenigma kianenigma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ho ho ho! 🎅 LGTM, except good comments from @rossbulat

@Ank4n Ank4n added A0-please_review Pull request needs code review. and removed A3-in_progress Pull request is in progress. No review needed at this stage. labels Dec 26, 2022
@Ank4n Ank4n requested a review from rossbulat December 26, 2022 10:57
@Ank4n
Copy link
Contributor Author

Ank4n commented Dec 26, 2022

bot merge

@paritytech-processbot paritytech-processbot bot merged commit c16472e into master Dec 26, 2022
@paritytech-processbot paritytech-processbot bot deleted the ankan/staking-admin branch December 26, 2022 15:48
rossbulat pushed a commit that referenced this pull request Dec 28, 2022
@Ank4n
Allow StakingAdmin to set min_commission (#13018)
3c4c61c 
* staking admin can set min commission

* ".git/.scripts/bench-bot.sh" pallet dev pallet_staking

* fmt

* fix for pr comments

Co-authored-by: command-bot <>
@Polkadot-Forum
Copy link

This pull request has been mentioned on Polkadot Forum. There might be relevant details there:

https://forum.polkadot.network/t/polkadot-release-analysis-v0-9-37/1736/1

@librelois librelois mentioned this pull request Jan 23, 2023
Closed
@AurevoirXavier AurevoirXavier mentioned this pull request Feb 8, 2023
Closed
@kacperzuk-neti kacperzuk-neti mentioned this pull request Feb 14, 2023
Merged
ltfschoen pushed a commit to ltfschoen/substrate that referenced this pull request Feb 22, 2023
@Ank4n @ltfschoen
Allow StakingAdmin to set min_commission (paritytech#13018)
3b2c199 
* staking admin can set min commission

* ".git/.scripts/bench-bot.sh" pallet dev pallet_staking

* fmt

* fix for pr comments

Co-authored-by: command-bot <>
ark0f pushed a commit to gear-tech/substrate that referenced this pull request Feb 27, 2023
@Ank4n @ark0f
Allow StakingAdmin to set min_commission (paritytech#13018)
60dd19f 
* staking admin can set min commission

* ".git/.scripts/bench-bot.sh" pallet dev pallet_staking

* fmt

* fix for pr comments

Co-authored-by: command-bot <>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rossbulat rossbulat rossbulat approved these changes

@kianenigma kianenigma kianenigma approved these changes

@andresilva andresilva Awaiting requested review from andresilva

@ruseinov ruseinov Awaiting requested review from ruseinov

@gpestana gpestana Awaiting requested review from gpestana

@ggwpez ggwpez Awaiting requested review from ggwpez

Assignees
No one assigned
Labels
A0-please_review Pull request needs code review. C3-medium PR touches the given topic and has a medium impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit
Projects
(Nominated) Proof of Stake
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Ank4n @Polkadot-Forum @kianenigma @rossbulat