This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
ed25519: Don't panic for invalid signature #12965
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We should not panic for an invalid signature when the `UseDalekExt` is given.
bkchr
added
A0-please_review
|
The CI pipeline was cancelled due to failure one of the required jobs. |
|
The CI pipeline was cancelled due to failure one of the required jobs. |
bkchr
commented
Dec 18, 2022
koute
approved these changes
Dec 19, 2022
davxy
reviewed
Dec 19, 2022
Comment on lines
+40
to
+41
| # Force the usage of ed25519, this is being used in `ed25519-dalek`. | ||
| ed25519 = { version = "1.5.2", optional = true } |
There was a problem hiding this comment.
Suggested change
| # Force the usage of ed25519, this is being used in `ed25519-dalek`. | |
| ed25519 = { version = "1.5.2", optional = true } |
Why you need this? We are using ed25519 from sp-core crate
There was a problem hiding this comment.
I don't have found it there :P
| @@ -59,6 +63,7 @@ std = [ | |||
| "futures", | |||
| "parking_lot", | |||
| "ed25519-dalek", | |||
| "ed25519", | |||
michalkucharczyk
approved these changes
Dec 19, 2022
lexnv
approved these changes
Dec 19, 2022
1 task
ltfschoen
pushed a commit
to ltfschoen/substrate
that referenced
this pull request
Feb 22, 2023
* ed25519: Don't panic for invalid signature We should not panic for an invalid signature when the `UseDalekExt` is given. * Update Cargo.toml * Update primitives/io/Cargo.toml
ark0f
pushed a commit
to gear-tech/substrate
that referenced
this pull request
Feb 27, 2023
* ed25519: Don't panic for invalid signature We should not panic for an invalid signature when the `UseDalekExt` is given. * Update Cargo.toml * Update primitives/io/Cargo.toml
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should not panic for an invalid signature when the
UseDalekExtis given.