This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
API for registering inactive funds #12813
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
muharem
reviewed
Nov 30, 2022
gavofyork
added
B0-silent
joepetrowski
approved these changes
Dec 1, 2022
|
@muharem a final review/approve, so we can merge? |
KiChjang
reviewed
Dec 2, 2022
muharem
reviewed
Dec 2, 2022
|
@muharem issues addressed. |
This comment was marked as spam.
This comment was marked as spam.
|
The CI pipeline was cancelled due to failure one of the required jobs. |
muharem
approved these changes
Dec 2, 2022
|
As a follow-up, all funds locked in nomination pools also have to be marked as deactivated now. The migration will be |
2 tasks
ltfschoen
pushed a commit
to ltfschoen/substrate
that referenced
this pull request
Feb 22, 2023
* API for registering inactive funds * Build fixes. * Update frame/treasury/src/lib.rs * Fix * Fixes * Fixes
ark0f
pushed a commit
to gear-tech/substrate
that referenced
this pull request
Feb 27, 2023
* API for registering inactive funds * Build fixes. * Update frame/treasury/src/lib.rs * Fix * Fixes * Fixes
10 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces
ActiveIssuanceOfwhich is the total issuance not including the treasury funds and any other funds marked as inactive withdeactivate. This should generally be used rather thanTotalIssuance.Balances pallet provides a migration which can be used to mark accounts with inactive funds (which, after the upgrade, we assume will be kept up to date with
deactivateandreactivate). For chains with XCM, this should be used to mark the Checking Account when upgraded.