Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Implement Zeroize for sp_core::sr25519::Pair #8130

Open
Voxelot opened this issue Feb 15, 2021 · 1 comment
Open

Implement Zeroize for sp_core::sr25519::Pair #8130

Voxelot opened this issue Feb 15, 2021 · 1 comment
Labels
A5-stale Pull request did not receive any updates in a long time. No review needed at this stage. Close it. J2-unconfirmed Issue might be valid, but it’s not yet known.

Comments

@Voxelot
Copy link

Voxelot commented Feb 15, 2021 •
edited
Loading

The sp-core newtype wrapper for a sr25519 keypair (sr25519::Pair) can now impl Zeroize, as the earlier upgrade to a non pre-release version of dalek introduces support for zeroize on Scalars / keypair secrets.

Implementing Zeroize would allow users of this type to utilize other libraries like https://crates.io/crates/secrecy.

Note: it also looks like the manual implementation of Zeroize for KeyPair is no longer necessary: https://github.com/w3f/schnorrkel/blame/8fa2ad3e9fbf0b652c724df6a87a4b3c5500f759/src/keys.rs#L688
@github-actions github-actions bot added the J2-unconfirmed Issue might be valid, but it’s not yet known. label Feb 15, 2021
@stale
Copy link

stale bot commented Jul 7, 2021

Hey, is anyone still working on this? Due to the inactivity this issue has been automatically marked as stale. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the A5-stale Pull request did not receive any updates in a long time. No review needed at this stage. Close it. label Jul 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
A5-stale Pull request did not receive any updates in a long time. No review needed at this stage. Close it. J2-unconfirmed Issue might be valid, but it’s not yet known.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Voxelot