Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

"Discovered external address" is printed too often #6874

Closed
tomaka opened this issue Aug 11, 2020 · 2 comments · Fixed by #6881
Closed

"Discovered external address" is printed too often #6874

tomaka opened this issue Aug 11, 2020 · 2 comments · Fixed by #6881
Labels
I4-annoyance The client behaves within expectations, however this “expected behaviour” itself is at issue.

Comments

@tomaka
Copy link
Contributor

tomaka commented Aug 11, 2020

The message "Discovered new external address for our node" happens every time an external address enters the list of known external addresses of our node.
The problem is that this list of known external addresses is heuristic. It can happen that an address enters the list, then leaves it, then re-enters it, and so on.

@tomaka tomaka added the I4-annoyance The client behaves within expectations, however this “expected behaviour” itself is at issue. label Aug 11, 2020
@tomaka
Copy link
Contributor Author

tomaka commented Aug 11, 2020

The question in play in this issue is: is the current behaviour about addresses entering/leaving the local list considered normal?
I believe that yes, in which case the solution is to not print the message every time but less often.

@andresilva
Copy link
Contributor

At least on my node I think the current behavior is expected and the heuristic is working fine. Most of the addresses that get re-discovered are either IPV6 (i.e. not used so often), or some private address which is very likely the result of some NAT translation in between. It makes sense that these unused addresses are evicted from the list (regardless of whether they're rediscovered afterwards).

This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
I4-annoyance The client behaves within expectations, however this “expected behaviour” itself is at issue.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants