Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Alpha 7 an alpha 8 are not fully released #6057

Closed
xlc opened this issue May 18, 2020 · 5 comments
Closed

Alpha 7 an alpha 8 are not fully released #6057

xlc opened this issue May 18, 2020 · 5 comments

Comments

@xlc
Copy link
Contributor

xlc commented May 18, 2020

https://docs.rs/crate/pallet-staking/2.0.0-alpha.8

Last successful build is alpha 6.

Please add a step to release pipeline to make sure the released version is actually compilable.

@xlc
Copy link
Contributor Author

xlc commented May 18, 2020

I am getting the same error as docs.rs and I can't identify what causes the error by looking at the code. There isn't any _phragmen::sp_runtime.

But I suspect this issue have something todo with the build pipeline modify Cargo.toml file during release. Pulling crates from tags in Github works perfectly fine.

@bkchr
Copy link
Member

bkchr commented May 18, 2020

@xlc the sp-phragmen-compact problem will be fixed by yanking the 2.0.0-dev.1 version. This will be done shortly by us.

@bkchr
Copy link
Member

bkchr commented May 18, 2020

The crate is yanked, please make sure that the specific version is removed from your Cargo.lock.

@xlc
Copy link
Contributor Author

xlc commented May 18, 2020

@bkchr cargo update seems fixes the build issue we have.

I will leave this open as I think there needs to be some process to ensure docs.rs builds successfully on publish.

@bkchr
Copy link
Member

bkchr commented May 19, 2020

Docs.rs could not build because of the same error. So, I going to close this. In the end it was an error that happened quite some time ago.

@bkchr bkchr closed this as completed May 19, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants