Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Nodes should only be inserted in the DHT of their chain #5825

Closed
tomaka opened this issue Apr 29, 2020 · 4 comments
Closed

Nodes should only be inserted in the DHT of their chain #5825

tomaka opened this issue Apr 29, 2020 · 4 comments
Labels
I4-annoyance The client behaves within expectations, however this “expected behaviour” itself is at issue.

Comments

@tomaka
Copy link
Contributor

tomaka commented Apr 29, 2020

We currently maintain one "legacy" global DHT, and one DHT per chain we are interested in.
However, at the moment, whenever we connect to a node, we immediately insert it in all of our DHTs.

This is wrong, and we should only insert a node after we know that it belongs to the correct chain.
@tomaka tomaka added the I4-annoyance The client behaves within expectations, however this “expected behaviour” itself is at issue. label Apr 29, 2020
@tomaka tomaka mentioned this issue Apr 29, 2020
Closed
@tomaka
Copy link
Contributor Author

tomaka commented May 14, 2020

Update: the "legacy" global DHT has been removed, but this issue is still more than relevant for the "per-chain" DHT.

@mxinden
Copy link
Contributor

mxinden commented May 14, 2020

Further discussion of restricting peers in the Kademlia routing table happens in libp2p/rust-libp2p#1560.

@tomaka tomaka mentioned this issue May 15, 2020
Closed
@tomaka
Copy link
Contributor Author

tomaka commented Jun 17, 2020

cc libp2p/rust-libp2p#1611

@mxinden mxinden mentioned this issue Jun 30, 2020
Closed
This was referenced Jul 8, 2020
Merged
Open
@tomaka
Copy link
Contributor Author

tomaka commented Jul 29, 2020

Should be fixed by #6549

@tomaka tomaka closed this as completed Jul 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
I4-annoyance The client behaves within expectations, however this “expected behaviour” itself is at issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tomaka @mxinden