Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Listen on IPv6 by default #5691

Closed
tomaka opened this issue Apr 17, 2020 · 4 comments · Fixed by #6064
Closed

Listen on IPv6 by default #5691

tomaka opened this issue Apr 17, 2020 · 4 comments · Fixed by #6064
Assignees

Comments

@tomaka
Copy link
Contributor

tomaka commented Apr 17, 2020

cc #5687
We had to revert listening by default because of benign libp2p errors.

@tomaka
Copy link
Contributor Author

tomaka commented Apr 20, 2020

To expand a little bit, there are two issues:

@bkchr
Copy link
Member

bkchr commented Apr 20, 2020

We probably need to set this this to false.

@twittner
Copy link
Contributor

We probably need to set this this to false.

By default IPV6_V6ONLY is false on Linux and true on Windows (according to https://docs.microsoft.com/en-us/windows/win32/winsock/ipproto-ipv6-socket-options). It is probably a good idea to explicitly set this option to false to ensure consistent behaviour accross platforms.

@twittner
Copy link
Contributor

I have opened libp2p/rust-libp2p#1555. Instead of setting IPV6_V6ONLY to false I set it to true. It allows us to bind two sockets to the same port, avoids mixed comparisons and works on more operating systems (on those that do not (want to) support IPv4-mapped IPv6 addresses such as OpenBSD).

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants