Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

[pallet_collective] set_members Extrinsic Allows Arbitrary 'prime' Argument #14353

Closed
2 tasks done
ToufeeqP opened this issue Jun 12, 2023 · 1 comment · Fixed by #14354
Closed
2 tasks done

[pallet_collective] set_members Extrinsic Allows Arbitrary 'prime' Argument #14353

ToufeeqP opened this issue Jun 12, 2023 · 1 comment · Fixed by #14354
Assignees
Labels
J0-enhancement An additional feature request. T1-runtime This PR/Issue is related to the topic “runtime”.

Comments

@ToufeeqP
Copy link
Contributor

Is there an existing issue?

  • I have searched the existing issues

Experiencing problems? Have you tried our Stack Exchange first?

  • This is not a support question.

Motivation

The motivation behind filing this issue is to address problematic behaviour in the pallet_collective module of the FRAME pallets. The current implementation of the set_members extrinsic allows for an arbitrary value to be passed as the prime argument, despite its intended purpose of representing one of the members in the new_members argument. This behaviour deviates from the expected functionality.

Request

The request is to modify the set_members extrinsic in the pallet_collective module of the FRAME pallets to enforce the intended usage of the prime argument.

Solution

To address this issue, I propose that the prime argument should be restricted to accepting only one of the accounts listed in the new_members argument. This modification will ensure that the set_members extrinsic functions as intended, allowing for correct and secure updates to the collective membership. I would be happy to raise a PR to fix this issue.

Are you willing to help with this request?

Yes!

@ToufeeqP ToufeeqP added the J0-enhancement An additional feature request. label Jun 12, 2023
@github-actions github-actions bot added the J2-unconfirmed Issue might be valid, but it’s not yet known. label Jun 12, 2023
@juangirini juangirini added the T1-runtime This PR/Issue is related to the topic “runtime”. label Jun 27, 2023
@ggwpez
Copy link
Member

ggwpez commented Jul 11, 2023

Yea sounds reasonable. Please go ahead if you like 😄

@ggwpez ggwpez removed the J2-unconfirmed Issue might be valid, but it’s not yet known. label Jul 11, 2023
@github-project-automation github-project-automation bot moved this from Backlog to Done in Runtime / FRAME Jul 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
J0-enhancement An additional feature request. T1-runtime This PR/Issue is related to the topic “runtime”.
Projects
Status: Done
3 participants