Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

pallet-mmr: gate MMR offchain canonicalization behind --enable-offchain-indexing=true #12531

Closed
Tracked by #1636
acatangiu opened this issue Oct 19, 2022 · 6 comments
Closed
Tracked by #1636

pallet-mmr: gate MMR offchain canonicalization behind --enable-offchain-indexing=true #12531

acatangiu opened this issue Oct 19, 2022 · 6 comments
Assignees
@serban300
Labels
I4-annoyance The client behaves within expectations, however this “expected behaviour” itself is at issue. U1-asap No need to stop dead in your tracks, however issue should be addressed as soon as possible.

Comments

@acatangiu
Copy link
Contributor

pallet-mmr

  1. uses sp_io::offchain_index API to save full MMR leaves content to offchain db,
  2. it also defines an offchain_worker() fn that does canonicalization of data in offchain db.

Issue
When --enable-offchain-indexing=true is not set, (1) doesn't write anything to offchain db, while (2) keeps on spamming error logs on failures to do canonicalization.

Proposed solution
Also move (2) under the --enable-offchain-indexing=true flag so it only runs when actually useful.
@acatangiu acatangiu moved this to Draft in Parity Roadmap Oct 19, 2022
@acatangiu acatangiu moved this from Draft to Open in Parity Roadmap Oct 19, 2022
@acatangiu acatangiu moved this to Need for Kusama 🗒 in BEEFY Oct 19, 2022
@acatangiu acatangiu added I4-annoyance The client behaves within expectations, however this “expected behaviour” itself is at issue. U1-asap No need to stop dead in your tracks, however issue should be addressed as soon as possible. labels Oct 19, 2022
@GuruKathryn
Copy link

Thank you for posting this! We have been suffering under this issue for a while. Would love to see it fixed.

@acatangiu
Copy link
Contributor Author

Thanks for reporting the issue!

@GuruKathryn GuruKathryn mentioned this issue Oct 19, 2022
Closed
@acatangiu
Copy link
Contributor Author

This will be fixed by implementing #12508

@GuruKathryn
Copy link

Awesome! 🎉

@acatangiu acatangiu moved this from Need for Kusama 🗒 to In Progress 🛠 in BEEFY Nov 11, 2022
This was referenced Nov 11, 2022
Closed
Closed
@acatangiu
Copy link
Contributor Author

temporary workarounds (while waiting for the fix) here: https://substrate.stackexchange.com/a/5432

@acatangiu
Copy link
Contributor Author

fixed by #12753

Repository owner moved this from In Progress 🛠 to Done ✅ in BEEFY Nov 29, 2022
@bLd75 bLd75 mentioned this issue Jan 3, 2023
Closed
2 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@serban300 serban300

Labels
I4-annoyance The client behaves within expectations, however this “expected behaviour” itself is at issue. U1-asap No need to stop dead in your tracks, however issue should be addressed as soon as possible.
Projects
No open projects
BEEFY
Status: Done ✅
Milestone
No milestone
Development

No branches or pull requests
3 participants
@serban300 @acatangiu @GuruKathryn