Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Move bitswap and transactions protocol out of sc-network #12133

Closed
2 of 3 tasks
bkchr opened this issue Aug 29, 2022 · 2 comments · Fixed by #12739
Closed
2 of 3 tasks

Move bitswap and transactions protocol out of sc-network #12133

bkchr opened this issue Aug 29, 2022 · 2 comments · Fixed by #12739
Assignees
Labels
I7-refactor Code needs refactoring. Z2-medium Can be fixed by a coder with good Rust knowledge but little knowledge of the codebase.

Comments

@bkchr
Copy link
Member

bkchr commented Aug 29, 2022

Alongside #8686 we should also move out transactions and bitswap protocol out of sc-network. These protocols should go on their own crates. While doing this we should also clear up Behaviour::new to take all ProtocolConfigs in the request_response_protocols vector. There should be no need that we list all the other protocols on individually.

@bkchr bkchr added I7-refactor Code needs refactoring. Z2-medium Can be fixed by a coder with good Rust knowledge but little knowledge of the codebase. labels Aug 29, 2022
@bkchr bkchr added this to Networking Aug 29, 2022
@bkchr bkchr moved this to Backlog 🗒 in Networking Aug 29, 2022
@bkchr
Copy link
Member Author

bkchr commented Aug 31, 2022

When moving out the bitswap protocol, we need to revert the changes done in this pr: #12082

@altonen
Copy link
Contributor

altonen commented Oct 3, 2022

The last bullet will be fixed as part of one of the upcoming pull requests that move syncing out of sc-network. Right now the protocols (even their names) are too deeply integrated into the code.

@the-right-joyce the-right-joyce moved this to Backlog 🗒 in SDK Node Oct 17, 2022
@the-right-joyce the-right-joyce moved this from Backlog 🗒 to In Progress 🛠 in SDK Node Oct 17, 2022
@altonen altonen moved this from In Progress 🛠 to Code in review 🧐 in SDK Node Nov 20, 2022
Repository owner moved this from Backlog 🗒 to Blocked ⛔️ in Networking Nov 22, 2022
Repository owner moved this from Code in review 🧐 to Done ✅ in SDK Node Nov 22, 2022
@altonen altonen moved this from Blocked ⛔️ to Done ✅ in Networking Nov 22, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
I7-refactor Code needs refactoring. Z2-medium Can be fixed by a coder with good Rust knowledge but little knowledge of the codebase.
Projects
Status: Done
Status: done
Development

Successfully merging a pull request may close this issue.

2 participants