Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

nomination-pools: clear pool metadata after a pool is deleted. #12077

Closed
kianenigma opened this issue Aug 20, 2022 · 2 comments · Fixed by #12154
Closed

nomination-pools: clear pool metadata after a pool is deleted. #12077

kianenigma opened this issue Aug 20, 2022 · 2 comments · Fixed by #12154
Assignees
@ruseinov
Labels
I3-bug The node fails to follow expected behavior. Z1-easy Can be fixed primarily by duplicating and adapting code by an intermediate coder
Milestone
Polkadot v0.9.29

Comments

@kianenigma
Copy link
Contributor

In fn dissolve_pool, the corresponding pool metadata has to be removed as well.

Currently, we forget to do this.

Also requires a small migration: iterate over all metadatas, if one does not have a corresponding bonded_pool, delete it. The migration could also be executed manually with providing the right system::kill_storage.
@kianenigma kianenigma added the I3-bug The node fails to follow expected behavior. label Aug 20, 2022
@kianenigma kianenigma moved this to 📕 Backlog in (Nominated) Proof of Stake Aug 20, 2022
@kianenigma kianenigma moved this from 📕 Backlog to ⌛️ Sometime-soon in (Nominated) Proof of Stake Aug 20, 2022
@kianenigma kianenigma added the Z1-easy Can be fixed primarily by duplicating and adapting code by an intermediate coder label Aug 20, 2022
@tifecool
Copy link
Contributor

Would like to attempt this

@tifecool
Copy link
Contributor

What do you mean by migration?

@tifecool tifecool mentioned this issue Aug 27, 2022
Closed
@kianenigma kianenigma added this to the Polkadot v0.9.29 milestone Aug 28, 2022
@ruseinov ruseinov mentioned this issue Aug 31, 2022
Merged
Repository owner moved this from ⌛️ Sometime-soon to ✅ Done in (Nominated) Proof of Stake Sep 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@ruseinov ruseinov

Labels
I3-bug The node fails to follow expected behavior. Z1-easy Can be fixed primarily by duplicating and adapting code by an intermediate coder
Projects
(Nominated) Proof of Stake
Status: ✅ Done
Milestone
Polkadot v0.9.29
Development

Successfully merging a pull request may close this issue.

[Fix] Make sure pool metadata is removed on pool dissolve paritytech/substrate
3 participants
@ruseinov @kianenigma @tifecool