Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changed consensus to manual-seal #42

Merged
merged 2 commits into from
Mar 18, 2022
Merged

Changed consensus to manual-seal #42

merged 2 commits into from
Mar 18, 2022

Conversation

PierreOssun
Copy link
Contributor

Hello,
I've changed consensus from aura & grandpa with 6 seconds block-time.
To manual-seal where blocks are authored at every transaction.
It makes transactions almost instant and is very practical for hacking & testing

@cla-bot-2021
Copy link

cla-bot-2021 bot commented Mar 16, 2022

User @PierreOssun, please sign the CLA here.

athei
athei approved these changes Mar 16, 2022
View reviewed changes
Copy link
Member

@athei athei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. Thanks for that. This makes development much more convenient.

@xgreenx
Copy link
Collaborator

xgreenx commented Mar 16, 2022

It closes #36

HCastano
HCastano reviewed Mar 16, 2022
View reviewed changes
Copy link
Contributor

@HCastano HCastano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one small question about the MinimumPeriod.

Tried it locally and it works great! What resource did you end up using to implement this?

runtime/Cargo.toml Outdated Show resolved Hide resolved
runtime/src/lib.rs Show resolved Hide resolved
@PierreOssun
Copy link
Contributor Author

PierreOssun commented Mar 17, 2022 •
edited
Loading

@HCastano
I've discussed with @atenjin from patract labs who has already changed consensus to manual-seal in their jupiter & europa nodes. And look at the work done on these nodes

@HCastano
Copy link
Contributor

@HCastano I've discussed with @atenjin from patract labs who has already changed consensus to manual-seal in their jupiter & europa nodes. And look at the work done on these nodes

Would be cool to see a short blog post about this 😉

HCastano
HCastano approved these changes Mar 18, 2022
View reviewed changes
Copy link
Contributor

@HCastano HCastano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@HCastano HCastano merged commit 9d140d5 into paritytech:main Mar 18, 2022
@cmichi cmichi mentioned this pull request Mar 22, 2022
Closed
@statictype statictype mentioned this pull request Apr 4, 2022
Closed
This was referenced Apr 22, 2022
Closed
Closed
This was referenced Feb 22, 2023
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HCastano HCastano HCastano approved these changes

@athei athei athei approved these changes

@cmichi cmichi Awaiting requested review from cmichi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@PierreOssun @xgreenx @HCastano @athei