remove std features (#71)

* remove scale_info and re-export PortableRegistry

* remove std features and make no_std

* fix clippy + doc links

* fix more nits

* run tests with all-features

* move extern crate std to lib.rs

.github/workflows/rust.yml

@@ -134,7 +134,7 @@ jobs:
         uses: actions-rs/[email protected]
         with:
           command: test
-          args: --all-targets --workspace
+          args: --all-targets --all-features --workspace
 
       - name: Cargo test docs
         uses: actions-rs/[email protected]

Cargo.toml

@@ -15,10 +15,10 @@ include = ["Cargo.toml", "src/**/*.rs", "README.md", "LICENSE"]
 rust-version = "1.81.0"
 
 [features]
-default = ["std", "serde", "from-string", "parser-ss58"]
+default = ["serde", "from-string", "parser-ss58"]
 
-# Only work in "std" environments:
-std = ["scale-bits/std", "either/use_std", "serde?/std", "serde_json/std"]
+# Internal feature for tests that needs std.
+__std = []
 
 # Enable support for parsing strings into Values.
 from-string = ["dep:yap"]

src/at.rs

@@ -22,7 +22,7 @@ use super::{Composite, Value, ValueDef, Variant};
 use crate::prelude::*;
 
 /// This trait allows indexing into [`Value`]s (and options of [`Value`]s)
-/// using the [`At::at()`] function. It's a little like Rust's [`::std::ops::Index`]
+/// using the [`At::at()`] function. It's a little like Rust's [`core::ops::Index`]
 /// trait, but adapted so that we can return and work with optionals.
 ///
 /// Indexing into a [`Value`] never panics; instead it will return `None` if a

src/lib.rs

@@ -29,10 +29,13 @@ of JSON data).
 - Accessed ergonomically via the [`At`] trait.
 */
 #![deny(missing_docs)]
-#![cfg_attr(not(feature = "std"), no_std)]
+#![no_std]
 
 extern crate alloc;
 
+#[cfg(feature = "__std")]
+extern crate std;
+
 mod at;
 mod macros;
 mod prelude;

src/prelude.rs

@@ -20,18 +20,12 @@
 // from `core` or `alloc`.
 pub use prelude_contents::*;
 
-#[cfg(feature = "std")]
-mod prelude_contents {
-    pub use std::prelude::rust_2021::*;
-}
-
-#[cfg(not(feature = "std"))]
 mod prelude_contents {
     pub use core::prelude::rust_2021::*;
 
     // The core prelude doesn't include things from
     // `alloc` by default, so add the ones we need that
-    // are otherwose exposed via the std prelude.
+    // are otherwise exposed via the std prelude.
     pub use alloc::borrow::ToOwned;
     pub use alloc::string::{String, ToString};
     pub use alloc::vec::Vec;

src/scale_impls/decode.rs

@@ -612,8 +612,7 @@ mod test {
         let scale_info::TypeDef::Composite(c) = &types.resolve(id).unwrap().type_def else {
             panic!("Couldn't get fields");
         };
-        let mut fields =
-            c.fields.iter().map(|f| scale_decode::Field::new(f.ty.id, f.name.as_deref()));
+        let mut fields = c.fields.iter().map(|f| scale_decode::Field::new(f.ty.id, f.name));
 
         // get some bytes to decode from:
         let foo = Foo { a: "Hello".to_owned(), b: true, c: 123 };

src/scale_impls/encode.rs

@@ -374,12 +374,11 @@ mod test {
     use super::*;
     use crate::value;
     use codec::{Compact, Encode};
-    use core::time::Duration;
     use scale_info::PortableRegistry;
 
     // Panic after some duration.
-    #[cfg(feature = "std")]
-    fn panic_after<T, F>(d: Duration, f: F) -> T
+    #[cfg(feature = "__std")]
+    fn panic_after<T, F>(d: core::time::Duration, f: F) -> T
     where
         T: Send + 'static,
         F: FnOnce() -> T,
@@ -631,9 +630,9 @@ mod test {
     // Prior to https://github.com/paritytech/scale-value/pulls/48, this test will take
     // too long and panic. #48 should ensure that this doesn't happen.
     #[test]
-    #[cfg(feature = "std")]
+    #[cfg(feature = "__std")]
     fn encoding_shouldnt_take_forever() {
-        panic_after(Duration::from_millis(100), || {
+        panic_after(core::time::Duration::from_millis(100), || {
             #[derive(scale_info::TypeInfo, codec::Encode)]
             struct A(bool);