Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strip invisible delimiters from type name #156

Merged
merged 3 commits into from
May 18, 2022

Conversation

ascjones
Copy link
Contributor

Closes #155

@ascjones ascjones requested a review from bkchr May 17, 2022 08:32
Copy link
Member

@bkchr bkchr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice and even with a test ❤️

test_suite/tests/derive.rs Outdated Show resolved Hide resolved
## [2.1.2] - 2022-05-18

### Fixed
- Strip invisible delimiters from type name [(#156)](https://github.com/paritytech/scale-info/pull/156)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be under unreleased maybe?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah but I was planning on releasing straight from this commit to avoid a separate PR

@ascjones
Copy link
Contributor Author

@ascjones ascjones merged commit e4de349 into master May 18, 2022
@ascjones ascjones deleted the aj/fix-invisible-delimiters branch May 18, 2022 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Strip pretty-printed invisible delimiters for type names
4 participants