-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include docs #223
Include docs #223
Conversation
- **Description**: A proxy module that allows account delegation. | ||
- **Functionality**: Enhances security and resource management by enabling accounts to delegate tasks to other accounts. | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should add sections for:
- AccountId20 support and how that is implemented with reference to relevant files.
- XCM Config used and some context on that.
- Benchmarking hardware used.
- Consensus details - collator selection and aura.
- Finality and average time to finality.
If there is anything else.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just added it. Please, let me know if that's sufficient or should be further extended.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should expand a bit more and link to the relevant files/sections in the code.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just expanded that section and included links to the relevant sources.
Just added some extra information about zombient and benchmarking and unified formatting using prettier |
@@ -45,15 +43,20 @@ To bootstrap a local instance of the blockchain, use the script [./zombienet.sh] | |||
|
|||
### Mainnet - Mythos local network. | |||
./zombienet.sh mainnet | |||
|
|||
### Testnet - Muse local network and AssetHub Parachain connected via HRMP channel. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
HRMP channels have to be manually created using ./scripts/hrmp-helper.sh
. That's why I excluded this one and the corresponding mainnet one. Simply in order not to overcomplicate the documentation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh yes you are right, I forgot about that one. We can add it in a concise way, let me rewrite it
This PR adds documentation about the Mythos parachain.