comment

paritytech · Apr 26, 2022 · 9a7e9b0 · 9a7e9b0
1 parent 0b745d7
commit 9a7e9b0
Showing 1 changed file with 14 additions and 2 deletions.
diff --git a/src/core.ts b/src/core.ts
@@ -53,7 +53,13 @@ const processSubconditionMissingApprovers = (
       userToAskForReview = userInfo
     } else if (userInfo.teams === null) {
       userToAskForReview.teams = null
-    } else if (userToAskForReview.teams !== null) {
+    } else if (
+      /*
+        Avoid registering a team for this user if their approval is supposed
+        to be requested individually
+      */
+      userToAskForReview.teams !== null
+    ) {
       userToAskForReview.teams = new Set([
         ...(userToAskForReview.teams ?? []),
         ...(userInfo?.teams ?? []),
@@ -908,7 +914,13 @@ export const runChecks = async ({ pr, ...ctx }: Context & { pr: PR }) => {
           userToAskForReview = userInfo
         } else if (userInfo.teams === null) {
           userToAskForReview.teams = null
-        } else if (userToAskForReview.teams !== null) {
+        } else if (
+          /*
+            Avoid registering a team for this user if their approval is supposed
+            to be requested individually
+          */
+          userToAskForReview.teams !== null
+        ) {
           userToAskForReview.teams = new Set([
             ...(userToAskForReview.teams ?? []),
             ...(userInfo?.teams ?? []),