less jmp

paritytech · Apr 26, 2022 · 6e770b7 · 6e770b7
1 parent f2a529d
commit 6e770b7
Showing 1 changed file with 5 additions and 9 deletions.
diff --git a/src/core.ts b/src/core.ts
@@ -528,11 +528,8 @@ export const runChecks = async ({ pr, ...ctx }: Context & { pr: PR }) => {
             const approvedBy: Set<string> = new Set()
 
             for (const review of latestReviews.values()) {
-              if (!review.isApproval) {
-                continue
-              }
-
               if (
+                review.isApproval &&
                 rule.subconditions.find(({ usersInfo }) => {
                   return usersInfo.has(review.user)
                 })
@@ -846,11 +843,10 @@ export const runChecks = async ({ pr, ...ctx }: Context & { pr: PR }) => {
               const approvedBy: Set<string> = new Set()
 
               for (const review of latestReviews.values()) {
-                if (!review.isApproval) {
-                  continue
-                }
-
-                if (subcondition.usersInfo.has(review.user)) {
+                if (
+                  review.isApproval &&
+                  subcondition.usersInfo.has(review.user)
+                ) {
                   approvedBy.add(review.user)
                 }
               }