-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Approve multiple candidates with a single signature #7554
base: sandreim/vrf_modulo_comapct_assignment
Are you sure you want to change the base?
Approve multiple candidates with a single signature #7554
Commits on Jul 28, 2023
-
Approve multiple candidates with a single signature
Signed-off-by: Alexandru Gheorghe <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 08c2381 - Browse repository at this point
Copy the full SHA 08c2381View commit details -
Add Runtime configuration for max_approval_coalesce_count/wait_millis
TODO: Migration is not correctly handled, should be done before versi testing. Signed-off-by: Alexandru Gheorghe <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 4901fee - Browse repository at this point
Copy the full SHA 4901feeView commit details -
Add zombienet for approval-coalescing
Signed-off-by: Alexandru Gheorghe <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 1e3b511 - Browse repository at this point
Copy the full SHA 1e3b511View commit details
Commits on Jul 31, 2023
-
Refactor timers to address review comments
Signed-off-by: Alexandru Gheorghe <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for cf68a10 - Browse repository at this point
Copy the full SHA cf68a10View commit details
Commits on Aug 2, 2023
-
Make wait time for caching relative to no-show
... additionally computed in ticks as it is done everywhere else. And added some tests to make sure approval-voting behaves the way we intended to. Signed-off-by: Alexandru Gheorghe <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for fd4b906 - Browse repository at this point
Copy the full SHA fd4b906View commit details -
Enforce target candidate is part of the signature
Signed-off-by: Alexandru Gheorghe <[email protected]>
2Configuration menu - View commit details
-
Copy full SHA for 2271c71 - Browse repository at this point
Copy the full SHA 2271c71View commit details -
Merge remote-tracking branch 'origin/sandreim/vrf_modulo_comapct_assi…
…gnment' into coalescing_of_approvals_cleanup
Configuration menu - View commit details
-
Copy full SHA for df410ff - Browse repository at this point
Copy the full SHA df410ffView commit details -
Fixup runtime configuration after rebase
Signed-off-by: Alexandru Gheorghe <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for f0f05c6 - Browse repository at this point
Copy the full SHA f0f05c6View commit details -
Merge remote-tracking branch 'origin/sandreim/vrf_modulo_comapct_assi…
…gnment' into coalescing_of_approvals_cleanup
Configuration menu - View commit details
-
Copy full SHA for 76a10c6 - Browse repository at this point
Copy the full SHA 76a10c6View commit details -
Signed-off-by: Alexandru Gheorghe <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for d31d1d0 - Browse repository at this point
Copy the full SHA d31d1d0View commit details
Commits on Aug 3, 2023
-
Fix bugs discovered during zombie-testing and unittest
Signed-off-by: Alexandru Gheorghe <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 6dfaecb - Browse repository at this point
Copy the full SHA 6dfaecbView commit details
Commits on Aug 4, 2023
-
Refactor the implementation a bit
Signed-off-by: Alexandru Gheorghe <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 1a2a5ec - Browse repository at this point
Copy the full SHA 1a2a5ecView commit details
Commits on Aug 8, 2023
-
Signed-off-by: Alexandru Gheorghe <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 81eb942 - Browse repository at this point
Copy the full SHA 81eb942View commit details -
approval-voting: fix migration from v1 to v2
Signed-off-by: Alexandru Gheorghe <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for ff0b35d - Browse repository at this point
Copy the full SHA ff0b35dView commit details -
Fix-up bugs in assignnments_coalescing of tranche0
Signed-off-by: Alexandru Gheorghe <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 2570c1e - Browse repository at this point
Copy the full SHA 2570c1eView commit details -
Signed-off-by: Alexandru Gheorghe <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 305a43a - Browse repository at this point
Copy the full SHA 305a43aView commit details -
Signed-off-by: Alexandru Gheorghe <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 5bb1e91 - Browse repository at this point
Copy the full SHA 5bb1e91View commit details -
Enable assignments v2 computing
Signed-off-by: Alexandru Gheorghe <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for a83cfb7 - Browse repository at this point
Copy the full SHA a83cfb7View commit details
Commits on Aug 10, 2023
-
Signed-off-by: Alexandru Gheorghe <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 98705e2 - Browse repository at this point
Copy the full SHA 98705e2View commit details -
Merge remote-tracking branch 'origin/sandreim/vrf_modulo_comapct_assi…
…gnment' into coalescing_of_approvals_v2
Configuration menu - View commit details
-
Copy full SHA for 3f28a5d - Browse repository at this point
Copy the full SHA 3f28a5dView commit details -
Fixup logic for restarting the node
Signed-off-by: Alexandru Gheorghe <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for aae2a4a - Browse repository at this point
Copy the full SHA aae2a4aView commit details -
Add metric to measure impact of coalescing of approvals
Signed-off-by: Alexandru Gheorghe <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 435d46a - Browse repository at this point
Copy the full SHA 435d46aView commit details
Commits on Aug 11, 2023
-
Add extra logs to improve debugability in versi
Signed-off-by: Alexandru Gheorghe <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 9016644 - Browse repository at this point
Copy the full SHA 9016644View commit details -
Fixup sending approval before assignment
Signed-off-by: Alexandru Gheorghe <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 1662e14 - Browse repository at this point
Copy the full SHA 1662e14View commit details
Commits on Aug 15, 2023
-
Count needed approvals by more than one third
Signed-off-by: Alexandru Gheorghe <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for af57831 - Browse repository at this point
Copy the full SHA af57831View commit details -
Add a few more metrics to understand versi behaviour
Signed-off-by: Alexandru Gheorghe <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for be65f42 - Browse repository at this point
Copy the full SHA be65f42View commit details
Commits on Aug 17, 2023
-
Don't send assignments to peers that are not part of the authorities …
…session ... there is not point in sending the assignments to peers that are not authorities in the session(collators or validators that are not authorities yet), because they won't be gossiped, so we are just wasting them. Signed-off-by: Alexandru Gheorghe <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 3ef84bf - Browse repository at this point
Copy the full SHA 3ef84bfView commit details -
No-shows are currently logged in the metric only at the moment of the approval candidate, but that doesn't account for votes that arrive late after the no-show period which is an early indicator that something might be off. Signed-off-by: Alexandru Gheorghe <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 1dbcb90 - Browse repository at this point
Copy the full SHA 1dbcb90View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3ac044e - Browse repository at this point
Copy the full SHA 3ac044eView commit details -
Signed-off-by: Alexandru Gheorghe <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 2cb6756 - Browse repository at this point
Copy the full SHA 2cb6756View commit details
Commits on Aug 18, 2023
-
Fix approval-distribution tests
... to take into consideration that we are not gossiping random assignments to non-validators nodes. Signed-off-by: Alexandru Gheorghe <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 0429549 - Browse repository at this point
Copy the full SHA 0429549View commit details -
Address initial review feedback
Signed-off-by: Alexandru Gheorghe <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 76823a4 - Browse repository at this point
Copy the full SHA 76823a4View commit details -
Add zombient test 0006-approval-voting-coalescing to pipeline
Signed-off-by: Alexandru Gheorghe <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for deff64f - Browse repository at this point
Copy the full SHA deff64fView commit details -
Signed-off-by: Alexandru Gheorghe <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 62a57b5 - Browse repository at this point
Copy the full SHA 62a57b5View commit details
Commits on Aug 21, 2023
-
Fix importing of approval out-of-view
Signed-off-by: Alexandru Gheorghe <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for f38697e - Browse repository at this point
Copy the full SHA f38697eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 903cef2 - Browse repository at this point
Copy the full SHA 903cef2View commit details -
Companion for substrate#14776 (paritytech#7648)
* Bump dalek * update lockfile for {"substrate"} --------- Co-authored-by: parity-processbot <>
Configuration menu - View commit details
-
Copy full SHA for ea027a8 - Browse repository at this point
Copy the full SHA ea027a8View commit details -
PVF worker: random fixes (paritytech#7649)
* PVF worker: random fixes - Fixes possible panic due to non-UTF-8 env vars (paritytech#7330 (comment)) - Very small refactor of some duplicated code * Don't need `to_str()` for comparison between OsString and str * Check edge cases that can cause env::remove_var to panic In case of a key or value that would cause env::remove_var to panic, we first log a warning and then proceed to attempt to remove the env var. * Make warning message clearer for end users * Backslash was unescaped, but can just remove it from error messages
Configuration menu - View commit details
-
Copy full SHA for 0bbe0a7 - Browse repository at this point
Copy the full SHA 0bbe0a7View commit details
Commits on Aug 22, 2023
-
Merge remote-tracking branch 'origin/sandreim/vrf_modulo_comapct_assi…
…gnment' into feature/approve_multiple_candidates_v2 Conflicts: node/core/runtime-api/src/cache.rs node/core/runtime-api/src/lib.rs node/network/approval-distribution/src/lib.rs node/network/protocol/src/lib.rs node/subsystem-types/src/messages.rs node/subsystem-types/src/runtime_client.rs primitives/src/runtime_api.rs primitives/src/vstaging/mod.rs runtime/parachains/src/builder.rs runtime/parachains/src/configuration.rs runtime/parachains/src/configuration/migration/v7.rs runtime/parachains/src/configuration/tests.rs runtime/parachains/src/runtime_api_impl/vstaging.rs runtime/rococo/src/lib.rs runtime/westend/src/lib.rs
Configuration menu - View commit details
-
Copy full SHA for 7bdf7dc - Browse repository at this point
Copy the full SHA 7bdf7dcView commit details -
Add BEEFY capabilities to Westend and Kusama (paritytech#7591)
* runtime: add BEEFY and MMR to Westend Signed-off-by: Adrian Catangiu <[email protected]> * runtime: add BEEFY and MMR to Kusama Signed-off-by: Adrian Catangiu <[email protected]> * node/service: enable BEEFY for Westend and Kusama Signed-off-by: Adrian Catangiu <[email protected]> * node/service: regenerate genesis keys for westend-native and kusama-native Since these keys are only used for development/local chains, also publish the secret seeds used to generate the public keys, so that developers can recover/generate the private key pairs if needed. Signed-off-by: Adrian Catangiu <[email protected]> * runtime: add session keys migration to add BEEFY to Westend and Kusama * runtime: fix migration * fix try-runtime build * cargo fmt * fix parachains slashing benchmark * address review comments * Apply suggestions from code review Co-authored-by: Bastian Köcher <[email protected]> * runtime: fix session keys migration --------- Signed-off-by: Adrian Catangiu <[email protected]> Co-authored-by: parity-processbot <> Co-authored-by: Bastian Köcher <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for e39c003 - Browse repository at this point
Copy the full SHA e39c003View commit details -
Bump actions/setup-node from 3.8.0 to 3.8.1 (paritytech#7639)
Bumps [actions/setup-node](https://github.com/actions/setup-node) from 3.8.0 to 3.8.1. - [Release notes](https://github.com/actions/setup-node/releases) - [Commits](actions/setup-node@v3.8.0...v3.8.1) --- updated-dependencies: - dependency-name: actions/setup-node dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for 8ce1716 - Browse repository at this point
Copy the full SHA 8ce1716View commit details -
Merge remote-tracking branch 'origin/sandreim/vrf_modulo_comapct_assi…
…gnment' into feature/approve_multiple_candidates_v2
Configuration menu - View commit details
-
Copy full SHA for 3264a00 - Browse repository at this point
Copy the full SHA 3264a00View commit details -
Bound number of assets which can be withdrawn to pay for execution. (p…
…aritytech#7641) * Bound number of assets which can be withdrawn to pay for execution. * ".git/.scripts/commands/fmt/fmt.sh" * Include ClaimAsset in limiting the assets * Change max assets to constant --------- Co-authored-by: command-bot <> Co-authored-by: Francisco Aguirre <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 9f1e9ea - Browse repository at this point
Copy the full SHA 9f1e9eaView commit details -
Enable approval-coalescing by default
Signed-off-by: Alexandru Gheorghe <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for d5fc80c - Browse repository at this point
Copy the full SHA d5fc80cView commit details -
Signed-off-by: Alexandru Gheorghe <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 301dab1 - Browse repository at this point
Copy the full SHA 301dab1View commit details -
Signed-off-by: Alexandru Gheorghe <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for d861d81 - Browse repository at this point
Copy the full SHA d861d81View commit details -
Signed-off-by: Alexandru Gheorghe <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for a216036 - Browse repository at this point
Copy the full SHA a216036View commit details -
Fix xcm-builder mock (paritytech#7652)
* Fix xcm-builder mock (preparation for monorepo) The CI fails here when the runtime-benchmarks feature is enabled in the workspace. Signed-off-by: Oliver Tale-Yazdi <[email protected]> * Update xcm/xcm-builder/Cargo.toml --------- Signed-off-by: Oliver Tale-Yazdi <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 759fe21 - Browse repository at this point
Copy the full SHA 759fe21View commit details
Commits on Aug 23, 2023
-
Merge remote-tracking branch 'origin/sandreim/vrf_modulo_comapct_assi…
…gnment' into feature/approve_multiple_candidates_v2
Configuration menu - View commit details
-
Copy full SHA for a908447 - Browse repository at this point
Copy the full SHA a908447View commit details -
Do not cleanup peer-knowledge on peer-connected/disconnected
Signed-off-by: Alexandru Gheorghe <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for e8ac355 - Browse repository at this point
Copy the full SHA e8ac355View commit details -
Companion: restructure macro related exports (paritytech#7626)
* move RuntimeDebug out of frame_support * move RuntimeDebug out of frame_support * fix xcm export * ".git/.scripts/commands/fmt/fmt.sh" * fix xcm intefration tests * fix cargo lock for xcm intefration tests * wip * restructure benchmarking macro related exports * update cargo lock --------- Co-authored-by: parity-processbot <>
Configuration menu - View commit details
-
Copy full SHA for 7f0eb5f - Browse repository at this point
Copy the full SHA 7f0eb5fView commit details -
Signed-off-by: Alexandru Gheorghe <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 7972d31 - Browse repository at this point
Copy the full SHA 7972d31View commit details -
Merge remote-tracking branch 'origin/sandreim/vrf_modulo_comapct_assi…
…gnment' into feature/approve_multiple_candidates_v2
Configuration menu - View commit details
-
Copy full SHA for e988782 - Browse repository at this point
Copy the full SHA e988782View commit details -
Build image with network vstaging
Signed-off-by: Alexandru Gheorghe <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for feefbbb - Browse repository at this point
Copy the full SHA feefbbbView commit details -
Fixup sending approvals more than once
Signed-off-by: Alexandru Gheorghe <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 71c08a4 - Browse repository at this point
Copy the full SHA 71c08a4View commit details -
Signed-off-by: Alexandru Gheorghe <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 0349441 - Browse repository at this point
Copy the full SHA 0349441View commit details
Commits on Aug 24, 2023
-
Bump chevdor/srtool-actions from 0.7.0 to 0.8.0 (paritytech#7660)
Bumps [chevdor/srtool-actions](https://github.com/chevdor/srtool-actions) from 0.7.0 to 0.8.0. - [Release notes](https://github.com/chevdor/srtool-actions/releases) - [Commits](chevdor/srtool-actions@v0.7.0...v0.8.0) --- updated-dependencies: - dependency-name: chevdor/srtool-actions dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for 52034bd - Browse repository at this point
Copy the full SHA 52034bdView commit details -
Bump rustls-webpki from 0.101.2 to 0.101.4 (paritytech#7653)
Bumps [rustls-webpki](https://github.com/rustls/webpki) from 0.101.2 to 0.101.4. - [Release notes](https://github.com/rustls/webpki/releases) - [Commits](rustls/webpki@v/0.101.2...v/0.101.4) --- updated-dependencies: - dependency-name: rustls-webpki dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for ebb610f - Browse repository at this point
Copy the full SHA ebb610fView commit details -
extend abridged host config (paritytech#7659)
added asynchronous backing params
Configuration menu - View commit details
-
Copy full SHA for f3da93d - Browse repository at this point
Copy the full SHA f3da93dView commit details
Commits on Aug 25, 2023
-
cli: disallow BEEFY and warp sync together (paritytech#7661)
Signed-off-by: Adrian Catangiu <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 598f4c6 - Browse repository at this point
Copy the full SHA 598f4c6View commit details -
update readme: archived repo (paritytech#7654)
* Update README.md * Update README.md
Configuration menu - View commit details
-
Copy full SHA for 52209dc - Browse repository at this point
Copy the full SHA 52209dcView commit details -
Merge remote-tracking branch 'origin/master' into approve_multiple_ca…
…ndidates_polkadot_sdk
Configuration menu - View commit details
-
Copy full SHA for a218e59 - Browse repository at this point
Copy the full SHA a218e59View commit details