This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
bump transaction version (polkadot & kusama) #5690
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coderobe
added
A0-please_review
|
Sounds reasonable to me. |
coderobe
added a commit
that referenced
this pull request
Jun 17, 2022
* kusama: bump transaction_version to 12 * polkadot: bump transaction_version to 13
|
Looks like westend is generally kept in line with these two so you might want to bump that also. If it were me I'd bump rococo up too. Not really convinced rococo should be at 0 given that it's a public testnet. |
|
They're not in sync & westend does not use the pallet, thus is unaffected |
paritytech-processbot bot
pushed a commit
that referenced
this pull request
Jun 21, 2022
* kusama: bump spec_version to 9250 * polkadot: bump spec_version to 9250 * rococo: bump spec_version to 9250 * westend: bump spec_version to 9250 * bump version to 0.9.25 * bump transaction version (polkadot & kusama) (#5690) * kusama: bump transaction_version to 12 * polkadot: bump transaction_version to 13
al3mart
pushed a commit
that referenced
this pull request
Jul 14, 2022
* kusama: bump spec_version to 9250 * polkadot: bump spec_version to 9250 * rococo: bump spec_version to 9250 * westend: bump spec_version to 9250 * bump version to 0.9.25 * bump transaction version (polkadot & kusama) (#5690) * kusama: bump transaction_version to 12 * polkadot: bump transaction_version to 13
28 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
we need a transaction_version bump on kusama and polkadot because we have index changes in the treasury pallet
It looks like the ordering changed when
spendwas introduced with paritytech/substrate#11124see also #5679 (comment)