Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Disable check-dependent-cumulus #5571

Closed
wants to merge 1 commit into from
Closed

Disable check-dependent-cumulus #5571

wants to merge 1 commit into from

Conversation

joao-paulo-parity
Copy link
Contributor

@joao-paulo-parity joao-paulo-parity commented May 20, 2022 •
edited
Loading

⚠️ Please don't forget to remove check-dependent-cumulus from required statuses in the GitHub repository settings

paritytech/diener#15 wasn't dealt with in reasonable time, so it's best to disable the check until that's fixed.

Related to paritytech/pipeline-scripts#45

Related to paritytech/diener#15

@joao-paulo-parity joao-paulo-parity added A2-insubstantial Pull request requires no code review (e.g., a sub-repository hash update). B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit. labels May 20, 2022
@joao-paulo-parity joao-paulo-parity requested a review from a team as a code owner May 20, 2022 08:54
@TriplEight
Copy link
Contributor

check-dependent-cumulus is not required as of now.

@paritytech-ci paritytech-ci requested a review from a team May 23, 2022 09:31
@joao-paulo-parity joao-paulo-parity marked this pull request as draft May 23, 2022 09:37
@joao-paulo-parity
Copy link
Contributor Author

Taking #5569 's pipelines as reference (https://gitlab.parity.io/parity/mirrors/polkadot/-/jobs/1584985 and https://gitlab.parity.io/parity/mirrors/polkadot/-/jobs/1584949) the problem of the patches not being respected (related to paritytech/pipeline-scripts#45, paritytech/diener#15 (comment) and paritytech/diener#15 (comment)) might've been sidestepped by 64f0948. That being the case the job is no longer broken although the issue still exists, it just might not apply to Cumulus anymore.

@bkchr Did something change in 64f0948 so that the issues you point out in paritytech/diener#15 (comment) and paritytech/diener#15 (comment) are no longer relevant? I ask this because https://gitlab.parity.io/parity/mirrors/polkadot/-/jobs/1584985 doesn't have the https://github.com/paritytech/polkadot? and https://github.com/paritytech/substrate? references shown around https://gitlab.parity.io/parity/mirrors/polkadot/-/jobs/1577990#L2211, therefore it's possible to deduce that the patches are being fully respected now.

@joao-paulo-parity
Copy link
Contributor Author

Can be closed as per paritytech/diener#15 (comment)

@joao-paulo-parity joao-paulo-parity deleted the disable-check-dependent-cumulus branch June 17, 2022 10:53
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sergejparity sergejparity sergejparity approved these changes

@TriplEight TriplEight TriplEight approved these changes

Assignees
No one assigned
Labels
A2-insubstantial Pull request requires no code review (e.g., a sub-repository hash update). B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@joao-paulo-parity @TriplEight @sergejparity