This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Remove SlotsCrowdloanIndexMigration & InjectValidatorsIntoVoterList #5374
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coderobe
added
A3-in_progress
29 tasks
github-actions
bot
added
A0-please_review
|
i'll also pick this in a follow-up PR against master if it passes review here |
runtime/common/src/crowdloan/mod.rs
Outdated
Comment on lines
52
to
53
| pub mod migration; | ||
|
|
There was a problem hiding this comment.
Why remove this?
Seems fine to expose this module, and keep the migration above.
There was a problem hiding this comment.
seemed sensible to remove the dead code together with its callsites
anyway, reverted
|
No need to remove the migration code in general, just remove its use. |
This reverts commit 1f8806c.
dvdplm
reviewed
Apr 25, 2022
coderobe
changed the title
dvdplm
approved these changes
Apr 25, 2022
bkchr
approved these changes
Apr 25, 2022
coderobe
added a commit
that referenced
this pull request
Apr 25, 2022
…5374) * Remove SlotsCrowdloanIndexMigration * Remove slots index migration code * Remove crowdloan index migration code * remove reference to migration * rustfmt * westend: remove unused import OnRuntimeUpgrade * kusama: remove unused import OnRuntimeUpgrade * polkadot: remove unused import OnRuntimeUpgrade * Revert "Remove crowdloan index migration code" This reverts commit fe84b59. * Revert "Remove slots index migration code" This reverts commit 62c5a28. * Revert "remove reference to migration" This reverts commit 1f8806c. * Remove InjectValidatorsIntoVoterList migration
coderobe
added a commit
that referenced
this pull request
Apr 25, 2022
…5374) (#5379) * Remove SlotsCrowdloanIndexMigration * Remove slots index migration code * Remove crowdloan index migration code * remove reference to migration * rustfmt * westend: remove unused import OnRuntimeUpgrade * kusama: remove unused import OnRuntimeUpgrade * polkadot: remove unused import OnRuntimeUpgrade * Revert "Remove crowdloan index migration code" This reverts commit fe84b59. * Revert "Remove slots index migration code" This reverts commit 62c5a28. * Revert "remove reference to migration" This reverts commit 1f8806c. * Remove InjectValidatorsIntoVoterList migration
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.