Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Companion to Substrate #11002 #5309

Merged
merged 4 commits into from
Apr 20, 2022
Merged

Companion to Substrate #11002 #5309

merged 4 commits into from
Apr 20, 2022

Conversation

emostov
Copy link
Contributor

@emostov emostov commented Apr 11, 2022

substrate companion: paritytech/substrate#11002

@emostov emostov added A0-please_review Pull request needs code review. B7-runtimenoteworthy D5-nicetohaveaudit ⚠️ PR contains trivial changes to logic that should be properly reviewed. labels Apr 11, 2022
@paritytech-ci paritytech-ci requested review from a team April 11, 2022 22:17
@paritytech-ci paritytech-ci requested review from a team April 19, 2022 07:58
@emostov
Copy link
Contributor Author

emostov commented Apr 19, 2022

AFAICT we need an approve from someone in this list:

usersToAskForReview Map(7) {
  'gavofyork' => { teams: Set(2) { 'locks-review', 'polkadot-review' } },
  'shawntabrizi' => { teams: Set(2) { 'locks-review', 'polkadot-review' } },
  'rphmeier' => { teams: Set(2) { 'locks-review', 'polkadot-review' } },
  'dvdplm' => { teams: Set(1) { 'polkadot-review' } },
  'andresilva' => { teams: Set(1) { 'polkadot-review' } },
  'drahnr' => { teams: Set(1) { 'polkadot-review' } },
  'eskimor' => { teams: Set(1) { 'polkadot-review' } }
}

@paritytech-processbot
Copy link

Waiting for commit status.

@paritytech-processbot
Copy link

Merge cancelled due to error. Error: Checks failed for f829c8e

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A0-please_review Pull request needs code review. C1-low PR touches the given topic and has a low impact on builders. D5-nicetohaveaudit ⚠️ PR contains trivial changes to logic that should be properly reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants