Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Seun txpool refactor #3419

Merged
6 commits merged into from
Jul 8, 2021
Merged

Seun txpool refactor #3419

6 commits merged into from
Jul 8, 2021

Conversation

seunlanlege
Copy link
Contributor

@github-actions github-actions bot added the A0-please_review Pull request needs code review. label Jul 6, 2021
@seunlanlege seunlanlege added A2-insubstantial Pull request requires no code review (e.g., a sub-repository hash update). B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit. labels Jul 6, 2021
@seunlanlege seunlanlege mentioned this pull request Jul 7, 2021
Merged
4 tasks
@gilescope gilescope requested a review from coriolinus July 8, 2021 09:53
expenses
expenses approved these changes Jul 8, 2021
View reviewed changes
Copy link
Contributor

@expenses expenses left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very trivial

@ghost
Copy link

ghost commented Jul 8, 2021

Waiting for commit status.

@seunlanlege
Copy link
Contributor Author 

| check if the wasm sources changed since v0.9.8
|
|
| wasm source files changed or the spec version in the substrate reference in
| the Cargo.lock but not the spec/impl version. If changes made do not alter
| logic, just bump 'impl_version'. If they do change logic, bump
| 'spec_version'.
| 
| source file directories:
| - runtime
| 
| version files: kusama polkadot westend
|
Cleaning up file based variables 00:00
ERROR: Job failed: command terminated with exit code 1

didn't touch any runtime code, not sure why this is failing

@ghost ghost merged commit 4d1ab29 into master Jul 8, 2021
@ghost ghost deleted the seun-txpool-refactor branch July 8, 2021 14:09
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@expenses expenses expenses approved these changes

@gilescope gilescope gilescope approved these changes

@gnunicorn gnunicorn gnunicorn approved these changes

@coriolinus coriolinus Awaiting requested review from coriolinus

Assignees
No one assigned
Labels
A0-please_review Pull request needs code review. A2-insubstantial Pull request requires no code review (e.g., a sub-repository hash update). B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@seunlanlege @gnunicorn @gilescope @expenses