Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Allow RollingSessionWindow to grow beyond dispute_period #6040

Closed
ordian opened this issue Sep 22, 2022 · 1 comment · Fixed by #6054
Closed

Allow RollingSessionWindow to grow beyond dispute_period #6040

ordian opened this issue Sep 22, 2022 · 1 comment · Fixed by #6054
Assignees
@sandreim
Labels
J0-enhancement An additional feature request. T4-parachains_engineering This PR/Issue is related to Parachains performance, stability, maintenance.

Comments

@ordian
Copy link
Member

ordian commented Sep 22, 2022 •
edited
Loading

Currently, if finality stalls on testnets for more than dispute_period, we need to manually fix with sudo forceApprove calls.
By keeping sessions in window for all the unfinalized chain, finality will recover automatically.

OOM is not a concern here, since SessionInfo is <40kb, so we can afford keeping thousands (months) of them in memory.
@ordian ordian added J0-enhancement An additional feature request. T4-parachains_engineering This PR/Issue is related to Parachains performance, stability, maintenance. labels Sep 22, 2022
@ordian ordian moved this to To do in Parachains-core Sep 22, 2022
@eskimor
Copy link
Member

eskimor commented Sep 23, 2022

Are there any other reasons approval-voting might permanently fail to approve a candidate?

@sandreim sandreim self-assigned this Sep 26, 2022
@sandreim sandreim moved this from To do to In progress in Parachains-core Sep 26, 2022
@sandreim sandreim mentioned this issue Sep 26, 2022
Merged
2 tasks
@sandreim sandreim moved this from In progress to Review in progress in Parachains-core Sep 26, 2022
@sandreim sandreim moved this from Review in progress to Versi burn-in in Parachains-core Sep 27, 2022
Repository owner moved this from Versi burn-in to Done in Parachains-core Oct 4, 2022
@ordian ordian mentioned this issue Oct 19, 2022
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@sandreim sandreim

Labels
J0-enhancement An additional feature request. T4-parachains_engineering This PR/Issue is related to Parachains performance, stability, maintenance.
Projects
No open projects
Parachains-core
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Keep sessions in window for the full unfinalized chain paritytech/polkadot
3 participants
@eskimor @ordian @sandreim