Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

dispute-coordinator: Make handle_import_statements return FatalResult #4396

Closed
eskimor opened this issue Nov 29, 2021 · 1 comment · Fixed by #6820
Closed

dispute-coordinator: Make handle_import_statements return FatalResult #4396

eskimor opened this issue Nov 29, 2021 · 1 comment · Fixed by #6820
Labels
T5-parachains_protocol This PR/Issue is related to Parachains features and protocol changes.

Comments

@eskimor
Copy link
Member

eskimor commented Nov 29, 2021

instead of Result here.

Reason being: We for example increase spam slots in this function, if then the import fails for some non fatal and unrelated reason, we should likely actually decrement previously incremented spam slots again, for non fatal errors - which is cumbersome and actually not needed, as in practice this function only has fatal errors right now, but it is not properly marked as such, because some used db related functions are not properly returning FatalResult yet.

We should therefore:

  • let handle_import_statements return FatalResult instead of Result (by fixing called functions to do the same).
  • Add documentation, why this function should only return FatalResult
@ordian ordian moved this to chore in Parachains-core Aug 16, 2022
@ordian ordian added the T5-parachains_protocol This PR/Issue is related to Parachains features and protocol changes. label Aug 16, 2022
@ordian ordian moved this from Chore to Backlog in Parachains-core Aug 16, 2022
@eskimor eskimor removed this from Parachains-core Dec 5, 2022
@eskimor
Copy link
Member Author

eskimor commented Feb 28, 2023

@BradleyOlson64 that's an easy/small one.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
T5-parachains_protocol This PR/Issue is related to Parachains features and protocol changes.
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

2 participants