Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Fix off-by-one in expected approved block-descriptions #3678

Closed
rphmeier opened this issue Aug 20, 2021 · 0 comments · Fixed by #3750
Closed

Fix off-by-one in expected approved block-descriptions #3678

rphmeier opened this issue Aug 20, 2021 · 0 comments · Fixed by #3750
Assignees
Labels
I3-bug Fails to follow expected behavior.

Comments

@rphmeier
Copy link
Contributor

We're getting many mismatch alerts from the relay-chain selection logic.

For example: 'Mismatch of anticipated block descriptions and block number difference. present_block_descriptions=59, target_number=8869933, subchain_number=8869991"

As 59+8869933=8869992, there's an off-by-one difference in what approval voting is producing and what the dispute coordinator is expecting. Or possibly, the sanity check has an off-by-one issue. This needs verification against intended behavior and a fix either to approval-voting or the sanity-check.

@rphmeier rphmeier added the I3-bug Fails to follow expected behavior. label Aug 20, 2021
@ordian ordian linked a pull request Aug 31, 2021 that will close this issue
1 task
@ghost ghost closed this as completed in #3750 Sep 1, 2021
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
I3-bug Fails to follow expected behavior.
Projects
None yet
2 participants