Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add README.md to umbrella #7600
base: master
Are you sure you want to change the base?
Add README.md to umbrella #7600
Changes from 4 commits
09049d3
8e30f12
3f4a632
bee4b29
6547459
c15db88
ce23e42
3b84211
577fb19
fe55076
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is great that this is a full e2e working example!
What is missing is the fact that there is no connection made between
polkadot-sdk
andpolkadot-sdk-frame
, which is also exported as a part of it.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't know there is a
polkadot-sdk-frame
. 👼 Do you mean it's recommended to useframe-support
andframe-system
from the exportedpolkadot-sdk-frame
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can learn about both here, and I think this should help you better structure this README to encompass both :)
https://blog.kianenigma.com/posts/tech/polkadot-sdk-2024/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To be clear,
polkadot-sdk-frame
has its own docs, what you should do here is:polkadot-sdk
should referencepolkadot-sdk-frame
and visa versa, avoiding confusion about one anotheruse polkadot_sdk::polkadot_sdk_frame as frame
and follow its tracks.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe also put this into the drop-down spoiler from above. Github supports
<details>
for that.