Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add genesis presets for coretime parachains #7476

Merged
merged 16 commits into from
Feb 19, 2025
Merged

add genesis presets for coretime parachains #7476

merged 16 commits into from
Feb 19, 2025

Conversation

clangenb
Copy link
Contributor

@clangenb clangenb commented Feb 5, 2025

Extracted from #7473.

Part of: #5704.

@clangenb clangenb requested review from a team as code owners February 5, 2025 12:01
@clangenb clangenb changed the title Cl/add coretime westend genesis presets add coretime westend genesis presets Feb 5, 2025
@bkontur
Copy link
Contributor

bkontur commented Feb 5, 2025

@clangenb nice, please clean also polkadot-parachain-bin e.g. here https://github.com/paritytech/polkadot-sdk/blob/master/cumulus/polkadot-parachain/src/chain_spec/people.rs#L166 with .with_genesis_config_preset_name(sp_genesis_builder::LOCAL_TESTNET_RUNTIME_PRESET) as we did with bridge_hubs.rs or asset_hubs.rs

@clangenb
Copy link
Contributor Author

clangenb commented Feb 5, 2025

Thanks for the quick review. Will do that for all my PRs!

@clangenb clangenb changed the title add coretime westend genesis presets add genesis presets for coretime parachains Feb 5, 2025
@clangenb clangenb mentioned this pull request Feb 5, 2025
Open
4 tasks
@paritytech-review-bot paritytech-review-bot bot requested a review from a team February 5, 2025 14:07
@clangenb
Copy link
Contributor Author

clangenb commented Feb 5, 2025 •
edited
Loading

I think I have added the necessary fixes. It is ready for another review. 🚀

@clangenb clangenb mentioned this pull request Feb 5, 2025
Draft
4 tasks
@clangenb
Copy link
Contributor Author

clangenb commented Feb 6, 2025

@bkontur the omni-bencher checks passed 🥳.

Is there anything I can do besides waiting to get reviews from the CI and release engineering team?

@clangenb
Copy link
Contributor Author

clangenb commented Feb 11, 2025 •
edited
Loading

Can we get the release engineering team to approve this too? :D

gui1117
gui1117 reviewed Feb 18, 2025
View reviewed changes
Copy link
Contributor

@gui1117 gui1117 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

endowment is changed a bit but it shouldn't matter,

I don't see why alice is removed as sudo key? but I am not very familiar with this part of the code.

Also it seems we use different para id inside the configuration

@gui1117
Copy link
Contributor

gui1117 commented Feb 18, 2025

/cmd prdoc --audience runtime-dev --bump minor

@github-actions GitHub Actions
Copy link
Contributor

Command "prdoc --audience runtime-dev --bump minor" has failed ❌! See logs here

@clangenb clangenb requested review from acatangiu, cheme, a team and koute as code owners February 19, 2025 09:02
@clangenb clangenb force-pushed the cl/add-coretime-westend-genesis-presets branch from bf57a04 to bcdc0fd Compare February 19, 2025 09:03
@clangenb clangenb requested a review from gui1117 February 19, 2025 09:08
gui1117
gui1117 approved these changes Feb 19, 2025
View reviewed changes
Copy link
Contributor

@gui1117 gui1117 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@gui1117 gui1117 added the T14-system_parachains This PR/Issue is related to system parachains. label Feb 19, 2025
@clangenb
Copy link
Contributor Author

/cmd prdoc --audience runtime_dev --bump minor

@clangenb
Copy link
Contributor Author

I think this PR is fine now, can someone add it to the merge queue?

@bkchr bkchr added this pull request to the merge queue Feb 19, 2025
Merged via the queue into paritytech:master with commit e9b745a Feb 19, 2025
249 of 255 checks passed
@clangenb clangenb deleted the cl/add-coretime-westend-genesis-presets branch February 27, 2025 06:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mordamax mordamax mordamax approved these changes

@bkchr bkchr bkchr approved these changes

@bkontur bkontur bkontur approved these changes

@gui1117 gui1117 gui1117 approved these changes

@alvicsam alvicsam alvicsam approved these changes

@acatangiu acatangiu Awaiting requested review from acatangiu

@cheme cheme Awaiting requested review from cheme

@koute koute Awaiting requested review from koute

Assignees
No one assigned
Labels
T14-system_parachains This PR/Issue is related to system parachains.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@clangenb @bkontur @gui1117 @mordamax @bkchr @alvicsam