-
Notifications
You must be signed in to change notification settings - Fork 835
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor proxy pallet to use Consideration instead #5336
Open
davidk-pt
wants to merge
31
commits into
master
Choose a base branch
from
davidk/refactor-proxy-pallet-to-use-consideration
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+415
−353
Open
Changes from 1 commit
Commits
Show all changes
31 commits
Select commit
Hold shift + click to select a range
ae5bbc7
Refactor proxy pallet to use Consideration trait
a11865a
Rust fmt
19dd381
Taplo format
479c15d
Manual changes for rust formatter
adb53a0
Additional prdoc
6463236
Remove dispatch result in infallible function
ad31477
Fix typos, comments, remove unneded type annotations
48a0f36
Refactor deposits per byte
cd4ae27
Merge branch 'master' into davidk/refactor-proxy-pallet-to-use-consid…
davidk-pt 13636eb
Migrate revive pallet to use new proxy version
dbd416e
Fix revive test formatting
1d8256b
Remove redundant clone
3b14812
Syntax sugar to proxy find
9ca8487
Change AtLeastOneStoragePrice to ZeroFootprintOr
c6fba2d
Merge branch 'master' into davidk/refactor-proxy-pallet-to-use-consid…
davidk-pt 7214145
Remove Currency from Proxy configuration
d98d39f
Merge branch 'master' into davidk/refactor-proxy-pallet-to-use-consid…
davidk-pt b9991f4
Create default test config for proxy pallet
a9e95d4
Formatting fixes
7cd10a6
Use scale encoding size for proxy/announcement
6f2a372
ProxiesVec/AnnouncementsVec type aliases
9d0c627
Replace log error with defensive! macro
03ecaf1
Remove balance checks from tests/benchmarks
4e76c2e
Merge branch 'master' into davidk/refactor-proxy-pallet-to-use-consid…
davidk-pt 0332ab4
Update new runtimes to use new proxy pallet config
c680f8d
Add Consideration::ensure_successful calls to benchmarks
fc3fa68
Fix proxy benchmarks
379f80b
Correct footprint calculation for proxies/announcements vec
4c48256
Rewrite updating announcements ticket
0e9e2e8
Add ensure_successful before every consideration creation
e19ef78
Remove ZeroFootprintOr converter
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Loading status checks…
Change AtLeastOneStoragePrice to ZeroFootprintOr
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where is this useful? Couldn't there still be a base deposit?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the behaviour of Proxy pallet before Consideration, there's no base deposit, if items in footprint is zero then storage price is 0. This is to keep Proxy pallet backwards compatible with this behaviour not to break existing runtimes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed ZeroFootprintOr, not it calculates based on size only