Reinitialize should allow to override existing config in collationGeneration #4833
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eneration subsystem
IMO sounds better to me and reflects more what the name says. |
|
WIll change it to that then! thank you @bkchr |
girazoki
changed the title
|
Changed @bkchr |
bkchr
approved these changes
Jun 21, 2024
bkchr
added
R0-silent
|
@girazoki can you write a prdoc? |
sure |
skunert
approved these changes
Jun 21, 2024
prdoc/pr_4833.prdoc
Outdated
|
|
||
| crates: | ||
| - name: polkadot-node-collation-generation | ||
| bump: none |
There was a problem hiding this comment.
Should be patch as the behaviour changes.
sandreim
approved these changes
Jun 21, 2024
Co-authored-by: Andrei Sandu <[email protected]>
bkchr
reviewed
Jun 23, 2024
Merged
via the queue into
paritytech:master
with commit Jun 23, 2024
f8feebc
142 of 158 checks passed
TarekkMA
pushed a commit
to moonbeam-foundation/polkadot-sdk
that referenced
this pull request
Aug 2, 2024
…eration (paritytech#4833) Currently the `Initialize` and `Reinitialize` messages in the collationGeneration subsystem fail if: - `Initialize` if there exists already another configuration and - `Reinitialize` if another configuration does not exist I propose to instead change the behaviour of `Reinitialize` to always set the config regardless of whether one exists or not. --------- Co-authored-by: Bastian Köcher <[email protected]> Co-authored-by: Andrei Sandu <[email protected]>
This was referenced Aug 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the
InitializeandReinitializemessages in the collationGeneration subsystem fail if:Initializeif there exists already another configuration andReinitializeif another configuration does not existI propose to instead change the behaviour of
Reinitializeto always set the config regardless of whether one exists or not.