Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Conditional required checks #4544

Merged
merged 10 commits into from
May 28, 2024
Merged

Conditional required checks #4544

merged 10 commits into from
May 28, 2024

Conversation

AndWeHaveAPlan
Copy link
Contributor

@AndWeHaveAPlan AndWeHaveAPlan commented May 22, 2024 •
edited
Loading

Workaround for skipped but required github checks. The idea is to trigger the workflow but filter out unaffected jobs or steps. See ci_cd 998 for details

In .github/workflows/check-changed-files.yml there is a reusable workflow thad does all the checks and publishes results as outputs. Example usage:

jobs:
  changes:
    permissions:
      pull-requests: read
    uses: ./.github/workflows/check-changed-files.yml
  some-job:
    needs: changes
    if: ${{ needs.changes.outputs.rust }}
 .......

@AndWeHaveAPlan AndWeHaveAPlan added the R0-silent Changes should not be mentioned in any release notes label May 28, 2024
@AndWeHaveAPlan AndWeHaveAPlan changed the title [DNM] conditional checks Conditional required checks May 28, 2024
@AndWeHaveAPlan AndWeHaveAPlan marked this pull request as ready for review May 28, 2024 09:53
@AndWeHaveAPlan AndWeHaveAPlan requested review from a team as code owners May 28, 2024 09:53
alvicsam
alvicsam approved these changes May 28, 2024
View reviewed changes
Copy link
Contributor

@alvicsam alvicsam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd add a brief comment at the beginning of the Check changes action why it's needed and what it does.

@AndWeHaveAPlan AndWeHaveAPlan added this pull request to the merge queue May 28, 2024
Merged via the queue into master with commit ea46ad5 May 28, 2024
155 of 156 checks passed
@AndWeHaveAPlan AndWeHaveAPlan deleted the es/conditional-gh-checks branch May 28, 2024 14:50
ordian added a commit that referenced this pull request May 30, 2024
@ordian
Merge branch 'master' into ao-statement-distribution-reenabling-prep
9684df4 
* master: (93 commits)
  Fix broken windows build (#4636)
  Beefy client generic on aduthority Id (#1816)
  pallet-staking: Put tests behind `cfg(debug_assertions)` (#4620)
  Broker new price adapter (#4521)
  Change `XcmDryRunApi::dry_run_extrinsic` to take a call instead (#4621)
  Update README.md (#4623)
  Publish `chain-spec-builder` (#4518)
  Add omni bencher & chain-spec-builder bins to release (#4557)
  Moves runtime macro out of experimental flag (#4249)
  Filter workspace dependencies in the templates (#4599)
  parachain-inherent: Make `para_id` more prominent (#4555)
  Add metric to measure the time it takes to gather enough assignments (#4587)
  Improve On_demand_assigner events (#4339)
  Conditional `required` checks (#4544)
  [CI] Deny adding git deps (#4572)
  [subsytem-bench] Remove redundant banchmark_name param (#4540)
  Add availability-recovery from systematic chunks (#1644)
  Remove workspace lints from templates (#4598)
  `sc-chain-spec`: deprecated code removed (#4410)
  [subsystem-benchmarks] Add statement-distribution benchmarks (#3863)
  ...
hitchhooker pushed a commit to ibp-network/polkadot-sdk that referenced this pull request Jun 5, 2024
@AndWeHaveAPlan @hitchhooker
Conditional required checks (paritytech#4544)
2d55c62 
Workaround for skipped but `required` github checks. The idea is to
trigger the workflow but filter out unaffected jobs or steps. See [ci_cd
998](https://github.com/paritytech/ci_cd/issues/988) for details

In `.github/workflows/check-changed-files.yml` there is a reusable
workflow thad does all the checks and publishes results as outputs.
Example usage:
```
jobs:
  changes:
    permissions:
      pull-requests: read
    uses: ./.github/workflows/check-changed-files.yml
  some-job:
    needs: changes
    if: ${{ needs.changes.outputs.rust }}
 ....... 
 ```
@AndWeHaveAPlan AndWeHaveAPlan mentioned this pull request Jun 6, 2024
Open
TarekkMA pushed a commit to moonbeam-foundation/polkadot-sdk that referenced this pull request Aug 2, 2024
@AndWeHaveAPlan @TarekkMA
Conditional required checks (paritytech#4544)
33f2093 
Workaround for skipped but `required` github checks. The idea is to
trigger the workflow but filter out unaffected jobs or steps. See [ci_cd
998](https://github.com/paritytech/ci_cd/issues/988) for details

In `.github/workflows/check-changed-files.yml` there is a reusable
workflow thad does all the checks and publishes results as outputs.
Example usage:
```
jobs:
  changes:
    permissions:
      pull-requests: read
    uses: ./.github/workflows/check-changed-files.yml
  some-job:
    needs: changes
    if: ${{ needs.changes.outputs.rust }}
 ....... 
 ```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alvicsam alvicsam alvicsam approved these changes

@EgorPopelyaev EgorPopelyaev EgorPopelyaev approved these changes

Assignees
No one assigned
Labels
R0-silent Changes should not be mentioned in any release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AndWeHaveAPlan @EgorPopelyaev @alvicsam