Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate XCMv2 #4131

Merged
merged 28 commits into from
May 27, 2024
Merged

Deprecate XCMv2 #4131

merged 28 commits into from
May 27, 2024

Conversation

franciscoaguirre
Copy link
Contributor

@franciscoaguirre franciscoaguirre commented Apr 15, 2024 •
edited
Loading

Marked XCMv2 as deprecated now that we have XCMv4.
It will be removed sometime around June 2024.

@franciscoaguirre franciscoaguirre marked this pull request as ready for review April 15, 2024 13:26
@franciscoaguirre franciscoaguirre requested a review from a team as a code owner April 15, 2024 13:26
bkontur
bkontur reviewed Apr 16, 2024
View reviewed changes
polkadot/xcm/src/lib.rs Show resolved Hide resolved
polkadot/xcm/src/lib.rs Show resolved Hide resolved
polkadot/xcm/src/v2/mod.rs Outdated Show resolved Hide resolved
polkadot/xcm/src/v3/mod.rs Show resolved Hide resolved
@franciscoaguirre franciscoaguirre added the T6-XCM This PR/Issue is related to XCM. label May 23, 2024
bkontur
bkontur approved these changes May 23, 2024
View reviewed changes
Copy link
Contributor

@bkontur bkontur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added some suggestions/nits to avoid using concrete XCM versions where not needed, so we don't need to do this again with newer versions

.../parachains/integration-tests/emulated/tests/bridges/bridge-hub-rococo/src/tests/send_xcm.rs Outdated Show resolved Hide resolved
.../parachains/integration-tests/emulated/tests/bridges/bridge-hub-rococo/src/tests/send_xcm.rs Outdated Show resolved Hide resolved
.../parachains/integration-tests/emulated/tests/bridges/bridge-hub-rococo/src/tests/send_xcm.rs Outdated Show resolved Hide resolved
.../parachains/integration-tests/emulated/tests/bridges/bridge-hub-rococo/src/tests/send_xcm.rs Outdated Show resolved Hide resolved
.../parachains/integration-tests/emulated/tests/bridges/bridge-hub-rococo/src/tests/send_xcm.rs Outdated Show resolved Hide resolved
...parachains/integration-tests/emulated/tests/bridges/bridge-hub-westend/src/tests/send_xcm.rs Outdated Show resolved Hide resolved
polkadot/xcm/pallet-xcm/src/benchmarking.rs Outdated Show resolved Hide resolved
polkadot/xcm/pallet-xcm/src/benchmarking.rs Outdated Show resolved Hide resolved
polkadot/xcm/pallet-xcm/src/benchmarking.rs Outdated Show resolved Hide resolved
cumulus/pallets/xcmp-queue/src/mock.rs Outdated Show resolved Hide resolved
franciscoaguirre and others added 14 commits May 24, 2024 09:35
@franciscoaguirre @bkontur
Update cumulus/parachains/integration-tests/emulated/tests/bridges/br…
8dbe0cb 
…idge-hub-rococo/src/tests/send_xcm.rs

Co-authored-by: Branislav Kontur <[email protected]>
@franciscoaguirre @bkontur
Update cumulus/parachains/integration-tests/emulated/tests/bridges/br…
9ccc37f 
…idge-hub-rococo/src/tests/send_xcm.rs

Co-authored-by: Branislav Kontur <[email protected]>
@franciscoaguirre @bkontur
Update cumulus/parachains/integration-tests/emulated/tests/bridges/br…
d049685 
…idge-hub-rococo/src/tests/send_xcm.rs

Co-authored-by: Branislav Kontur <[email protected]>
@franciscoaguirre @bkontur
Update cumulus/parachains/integration-tests/emulated/tests/bridges/br…
7a4cd57 
…idge-hub-rococo/src/tests/send_xcm.rs

Co-authored-by: Branislav Kontur <[email protected]>
@franciscoaguirre @bkontur
Update cumulus/parachains/integration-tests/emulated/tests/bridges/br…
3e01c8a 
…idge-hub-rococo/src/tests/send_xcm.rs

Co-authored-by: Branislav Kontur <[email protected]>
@franciscoaguirre @bkontur
Update cumulus/parachains/integration-tests/emulated/tests/bridges/br…
cec84ae 
…idge-hub-westend/src/tests/send_xcm.rs

Co-authored-by: Branislav Kontur <[email protected]>
@franciscoaguirre @bkontur
Update cumulus/parachains/integration-tests/emulated/tests/bridges/br…
3f0414f 
…idge-hub-westend/src/tests/send_xcm.rs

Co-authored-by: Branislav Kontur <[email protected]>
@franciscoaguirre @bkontur
Update cumulus/parachains/integration-tests/emulated/tests/bridges/br…
b2f1291 
…idge-hub-westend/src/tests/send_xcm.rs

Co-authored-by: Branislav Kontur <[email protected]>
@franciscoaguirre @bkontur
Update cumulus/parachains/integration-tests/emulated/tests/bridges/br…
45a1a2e 
…idge-hub-westend/src/tests/send_xcm.rs

Co-authored-by: Branislav Kontur <[email protected]>
@franciscoaguirre @bkontur
Update cumulus/parachains/integration-tests/emulated/tests/bridges/br…
0c56171 
…idge-hub-westend/src/tests/send_xcm.rs

Co-authored-by: Branislav Kontur <[email protected]>
@franciscoaguirre @bkontur
Update polkadot/xcm/pallet-xcm/src/benchmarking.rs
4ccedb5 
Co-authored-by: Branislav Kontur <[email protected]>
@franciscoaguirre @bkontur
Update polkadot/xcm/pallet-xcm/src/benchmarking.rs
2e1b596 
Co-authored-by: Branislav Kontur <[email protected]>
@franciscoaguirre @bkontur
Update polkadot/xcm/pallet-xcm/src/benchmarking.rs
29ed18c 
Co-authored-by: Branislav Kontur <[email protected]>
@franciscoaguirre
chore(xcmp-queue): use latest and older instead of hardcoding versions
21f60dd
@paritytech-cicd-pr
Copy link

The CI pipeline was cancelled due to failure one of the required jobs.
Job name: cargo-clippy
Logs: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/6287136

@franciscoaguirre franciscoaguirre added this pull request to the merge queue May 27, 2024
Merged via the queue into master with commit 9201f9a May 27, 2024
154 of 157 checks passed
@franciscoaguirre franciscoaguirre deleted the deprecate-xcm-v2 branch May 27, 2024 06:36
@Polkadot-Forum
Copy link

This pull request has been mentioned on Polkadot Forum. There might be relevant details there:

https://forum.polkadot.network/t/psa-xcmv2-deprecation/8367/1

hitchhooker pushed a commit to ibp-network/polkadot-sdk that referenced this pull request Jun 5, 2024
@franciscoaguirre @bkontur @hitchhooker
Deprecate XCMv2 (paritytech#4131)
e2fbe71 
Marked XCMv2 as deprecated now that we have XCMv4.
It will be removed sometime around June 2024.

---------

Co-authored-by: Branislav Kontur <[email protected]>
TarekkMA pushed a commit to moonbeam-foundation/polkadot-sdk that referenced this pull request Aug 2, 2024
@franciscoaguirre @bkontur @TarekkMA
Deprecate XCMv2 (paritytech#4131)
4ddcbd4 
Marked XCMv2 as deprecated now that we have XCMv4.
It will be removed sometime around June 2024.

---------

Co-authored-by: Branislav Kontur <[email protected]>
@chungquantin chungquantin mentioned this pull request Aug 15, 2024
Merged
This was referenced Aug 21, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bkontur bkontur bkontur approved these changes

@svyatonik svyatonik svyatonik approved these changes

@ggwpez ggwpez Awaiting requested review from ggwpez

@liamaharon liamaharon Awaiting requested review from liamaharon

@serban300 serban300 Awaiting requested review from serban300

@acatangiu acatangiu Awaiting requested review from acatangiu

Assignees
No one assigned
Labels
T6-XCM This PR/Issue is related to XCM.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@franciscoaguirre @paritytech-cicd-pr @Polkadot-Forum @svyatonik @bkontur