Enable mainnet system parachains to use async backing-enabled collator #3630
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
s0me0ne-unkn0wn
added
the
T14-system_parachains
s0me0ne-unkn0wn
changed the title
seadanda
reviewed
Apr 6, 2024
bkontur
reviewed
Apr 6, 2024
s0me0ne-unkn0wn
force-pushed
the
s0me0ne/async-backing-mainnet-system-parachains
branch
from
6c838fd
to
ae62e6e
Compare
alexggh
reviewed
Apr 9, 2024
|
A lot of code moved here and there because the litep2p stuff got merged, please have one more look. |
bkchr
approved these changes
Apr 11, 2024
|
@s0me0ne-unkn0wn I was under the impression that there was something pending before this PR could be merged so I've been holding off on approval, but I've just seen in the chat that you're happy for it to be merged. What were you referring to in this comment: https://github.com/paritytech/devops/issues/3261#issuecomment-2047474907 |
…ng-mainnet-system-parachains
…-backing-mainnet-system-parachains
|
@seadanda done that! |
seadanda
approved these changes
Apr 11, 2024
s0me0ne-unkn0wn
deleted the
s0me0ne/async-backing-mainnet-system-parachains
branch
14 tasks
This was referenced Jun 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is phase 2 of async backing enablement for the system parachains on the production networks.
It should be merged after polkadot-fellows/runtimes#228 is enacted. After it is released,all the system parachain collators should be upgraded, and then we can proceed with phase 3, which will enable async backing in the runtimes.UPDATE: Indeed, we don't need to wait for the runtime upgrade enactions. The lookahead collator handles the transition by itself, so we can upgrade ASAP.
Scope of changes
Here, we eliminate the dichotomy of having "generic Aura collators" for the production system parachains and "lookahead Aura collators" for the testnet system parachains. Now, all the collators are started as lookahead ones, preserving the logic of transferring from the shell node to Aura-enabled collators for the asset hubs. So, indeed, it simplifies the parachain service logic, which cannot but rejoice.